Follow-up from "Refactor a service responsible for creating a pipeline"
The following discussions from !14482 (merged) should be addressed:
-
@ayufan started a discussion: (+1 comment) I would also probably like to see:
pipeline = Ci::Pipeline.new
(we don't need to memorize the object)
and then have
Gitlab::Ci::Pipeline::Chain::Build
to fill all these parameters.Feel free to create extra issue for that.
-
@zj started a discussion: (+1 comment) Not a fan of this idea, I feel the whole sequence pattern should not expose this. I understand why its needed, but would ask to look for another solution.
-
@zj started a discussion: (+1 comment) Why don't we let
#perform!
return a value? Possibly two? The first being the current, not final, result and the second an error value? Its a bit golang like, which might be bad in a Ruby context.