Skip to content
Snippets Groups Projects

Refactor a service responsible for creating a pipeline

Merged Grzegorz Bizon requested to merge backstage/gb/refactor-pipeline-create-service into master
All threads resolved!

What does this MR do?

Reactor pipeline creation service

Does this MR meet the acceptance criteria?

  • Tests added for this feature/bug
  • Has been reviewed by Backend

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ce#37563
Closes #34415 (closed)

Edited by Grzegorz Bizon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kamil Trzcińśki
  • Grzegorz Bizon added 1 commit

    added 1 commit

    • 3e60d62c - Add class that handles pipeline creation sequence

    Compare with previous version

  • Grzegorz Bizon added 2 commits

    added 2 commits

    • 609fa45f - Split pipeline chain builder validation class
    • fa3fb23f - Move pipeline builder validation chain to a module

    Compare with previous version

  • Grzegorz Bizon added 2 commits

    added 2 commits

    • da15b388 - Add specs for pipeline builder abilities validator
    • 1a8777c8 - Fix coding style offenses in pipeline chain classes

    Compare with previous version

  • Grzegorz Bizon added 2 commits

    added 2 commits

    • 53cad500 - Add missing tests for pipeline chain access validator
    • f6bd832f - Fix some code style offenses in pipeline chain classes

    Compare with previous version

  • Grzegorz Bizon unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Grzegorz Bizon marked the checklist item Tests added for this feature/bug as completed

    marked the checklist item Tests added for this feature/bug as completed

  • Grzegorz Bizon changed milestone to %10.1

    changed milestone to %10.1

  • Grzegorz Bizon added 1 commit

    added 1 commit

    • 835bdcb8 - Add specs for pipeline chain builder sequence class

    Compare with previous version

  • mentioned in issue #34415 (closed)

  • Grzegorz Bizon changed the description

    changed the description

  • Author Maintainer

    @ayufan Please review (after merge request diffs are regenerated with 057a8b70). Thanks! :yellow_heart:

  • assigned to @ayufan

  • Grzegorz Bizon
  • Grzegorz Bizon
  • Grzegorz Bizon added 1 commit

    added 1 commit

    • 057a8b70 - Add test for head pipeline assignment when skipped

    Compare with previous version

  • Grzegorz Bizon
  • Grzegorz Bizon added 1 commit

    added 1 commit

    • 26e73c2e - Add some minor improvements to pipeline creation chain

    Compare with previous version

  • Kamil Trzcińśki
  • Kamil Trzcińśki
  • Zeger-Jan van de Weg
  • Zeger-Jan van de Weg
  • Kamil Trzcińśki resolved all discussions

    resolved all discussions

  • mentioned in issue #38460

  • Kamil Trzcińśki approved this merge request

    approved this merge request

  • mentioned in commit 0bba522f

  • Please register or sign in to reply
    Loading