Skip to content
Snippets Groups Projects

Fix PlantUML integration in GFM

Merged username-removed-378947 requested to merge plantuml-filter-after-highlight into master
All threads resolved!

What does this MR do?

Use "lang" attribute instead of "class" in PlantumlFilter.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Fixes #30557 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @jarka Thanks for reviewing. I added the comment and I'm passing to @DouweM.

  • added 90 commits

    Compare with previous version

  • username-removed-378947 resolved all discussions

    resolved all discussions

  • In my environment it has been correctly rendered by your modifications. Thanks!

    • GitLab-ce 9.0.5
    • Tomcat7 + PlantUML Server 20170413-0753 / version 201709
  • added 1 commit

    • 8edcdcea - Fix PlantUML integration in GFM

    Compare with previous version

  • username-removed-378947 changed title from Move PlantumlFilter after SyntaxHighlightFilter in GfmPipeline to Fix PlantUML integration in GFM

    changed title from Move PlantumlFilter after SyntaxHighlightFilter in GfmPipeline to Fix PlantUML integration in GFM

  • I think this should also go in 9.0 so once picked into 9.1 we'll have to update the milestone. /cc @godfat @felipe_artur @twk3

    Edited by James Lopez
  • mentioned in issue #31059 (closed)

  • username-removed-378947 resolved all discussions

    resolved all discussions

  • added 252 commits

    Compare with previous version

  • username-removed-443319 approved this merge request

    approved this merge request

  • username-removed-443319 enabled an automatic merge when the pipeline for 0945dc41 succeeds

    enabled an automatic merge when the pipeline for 0945dc41 succeeds

  • mentioned in commit 08b2e7cd

  • Picked into 9-1-stable, will go into 9.1.0-rc6

  • changed milestone to %9.0

  • mentioned in commit d9a407d1

  • Picked into stable. Will be in 9.0.6.

  • mentioned in commit bd2c22d6

  • As always with you guys, I'm very impressed with your responsiveness!!

  • Please register or sign in to reply
    Loading