Fix JavaScript translations that are using a namespace
What does this MR do?
It fixes some JavaScript translations that are using namespaces
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Thanks to @marcia for reporting this:
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
changed milestone to %9.2
@iamphill I'm not sure if it was broken from the beginning, I recall it was working fine, anyways I'm sending this small fix.
Thanks @marcia for reporting this. REF: https://gitlab.slack.com/archives/C0AR2KW4B/p1495152561210710
@selfup @timothyandrew can you please cherry-pick this small fix: https://gitlab.com/gitlab-org/gitlab-ce/commit/851e69e5546. cc: @iamphill
Edited by Rubén Dávilaassigned to @rdavila
assigned to @DouweM
assigned to @iamphill
@iamphill can you please review and merge it?
mentioned in issue #31934 (closed)
thanks @rdavila :)
There's also this:
Is this more or less the same thing or should be investigated from another issue?
Is this more or less the same thing or should be investigated from another issue?
@marcia not sure if you're referring to a translation here, can you please clarify?
Just spotted another one:
That's because this fix has not been picked in the stable branch: https://gitlab.com/gitlab-org/gitlab-ce/commit/851e69e5546 cc: @selfup @timothyandrew
@rdavila @iamphill once everything is solved could you add regression label? They will have the highest priority atm
mentioned in commit 01a7f333
added regression label
mentioned in commit 3eda0c4f
not sure if you're referring to a translation here, can you please clarify?
Sure :) Nope, not related to the translations I think. What I'm seeing there is, in the "median" data it says "not enough data" but if you expand it, you see there's plenty of data there. So, I wonder why the "median" is not displaying any data.
@marcia I think this is a good question for the fathers of the feature :) /cc @fatihacet @timothyandrew