Skip to content
Snippets Groups Projects

Fix system note comparison and standardize note setup

All threads resolved!

What does this MR do?

  • Fix system note comparison. We were comparing against double the message because there were two .original-note-content and jQuery combines the two nodes, https://jsfiddle.net/574qfbvx/
  • Standardize note setup to dry things up and make sure if a system note ever does need to update, we collapse it properly.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

  • MR commit system notes were oddly displayed after polling update

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #32551 (closed)

Edited by username-removed-892863

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-892863
  • username-removed-892863
  • Phil Hughes resolved all discussions

    resolved all discussions

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes enabled an automatic merge when the pipeline for f6743cc4 succeeds

    enabled an automatic merge when the pipeline for f6743cc4 succeeds

  • added 1 commit

    • 682cfbb4 - Fix system note comparison and standardize note setup

    Compare with previous version

  • @iamphill MWPS again please 👯

  • username-removed-892863 changed the description

    changed the description

  • username-removed-892863 marked the checklist item All builds are passing as completed

    marked the checklist item All builds are passing as completed

  • @filipa ready to merge.

    Looks like @iamphill is at a conference today.

  • Thank you @MadLittleMods! 🎉

  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • Filipa Lacerda approved this merge request

    approved this merge request

  • Filipa Lacerda mentioned in commit c19d58de

    mentioned in commit c19d58de

  • Picked into 9-2-stable, will go into 9.2.0-rc7.

  • Filipa Lacerda mentioned in commit 95979035

    mentioned in commit 95979035

  • Please register or sign in to reply
    Loading