An error occurred while fetching the assigned milestone of the selected merge_request.
Fix system note comparison and standardize note setup
All threads resolved!
All threads resolved!
What does this MR do?
- Fix system note comparison. We were comparing against double the message because there were two
.original-note-content
and jQuery combines the two nodes, https://jsfiddle.net/574qfbvx/ - Standardize note setup to dry things up and make sure if a system note ever does need to update, we collapse it properly.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
- MR commit system notes were oddly displayed after polling update
Does this MR meet the acceptance criteria?
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #32551 (closed)
Edited by username-removed-892863
Merge request reports
Activity
- Resolved by Phil Hughes
- Resolved by Phil Hughes
- Resolved by Filipa Lacerda
assigned to @iamphill
added regression label
enabled an automatic merge when the pipeline for f6743cc4 succeeds
added 1 commit
- 682cfbb4 - Fix system note comparison and standardize note setup
@iamphill MWPS again please
👯 assigned to @filipa
Thank you @MadLittleMods!
🎉 mentioned in commit c19d58de
mentioned in commit 95979035
Please register or sign in to reply