Skip to content
Snippets Groups Projects

Display GPG status loading spinner only when Ajax request is made

Merged Winnie Hellmann requested to merge winh-gpg-status-spinners into master

What does this MR do?

Remove the loading indicator from GPG status badges until https://gitlab.com/gitlab-org/gitlab-ce/issues/36046 has been implemented.

Screenshots

Before After
Screen_Shot_2017-08-07_at_09.53.15 Screen_Shot_2017-08-07_at_09.51.58
Screen_Shot_2017-08-07_at_09.53.23 Screen_Shot_2017-08-07_at_09.52.20

What are the relevant issue numbers?

fixes #35699 (closed)

Merge request reports

Pipeline #10862935 passed with warnings

Pipeline passed with warnings on winh-gpg-status-spinners

Test coverage 71.31% from 2 jobs
Approval is optional

Merged by Phil HughesPhil Hughes 7 years ago (Aug 15, 2017 8:20am UTC)

Pipeline #10874954 failed

Pipeline failed for ae06b5db on master

Test coverage 49.97% from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading