Replace 'source/search_code.feature' spinach test with an rspec analog

What does this MR do?

This MR does these:

1. It refactors spec/features/projects/files/find_files_spec.rb spec.
2. It adds a new test to cover the search_code.feature spinach spec.
3. It removes source/search_code.feature spec

Why was this MR needed?

This is a part of spinach tests removal campaign.

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests added for this feature/bug
• Review
  • Has been reviewed by UX
  • Has been reviewed by Frontend
  • Has been reviewed by Backend
  • Has been reviewed by Database
• Conform by the merge request performance guides
• Conform by the style guides
• Squashed related commits together

What are the relevant issue numbers?

#23036 (moved)

@rymai here's another one spinach replacement MR. Could you review it, please?

I've refactored already existed rspec spec which fits the spinach spec that being removed + added one more test from the spinach spec.

Another point is changelog entry's type. It's not obvious what category this MR should fall into, so I've chosen the other variant.

assigned to @rymai

mentioned in issue #23036 (moved)

marked the checklist item Changelog entry added, if necessary as completed

marked the checklist item Tests added for this feature/bug as completed

@blackst0ne Since Rémy is on vacation for 2 weeks, I'll review it hope you don't mind.

assigned to @godfat

@blackst0ne Thanks! Some minor comments about removing more steps and other minor tweaks.

changed milestone to %10.0

assigned to @blackst0ne

@godfat I've resolved all discussions. One of them I didn't mark as resolved because there is a question to you in there.

assigned to @godfat

resolved all discussions

@blackst0ne Thanks! Looks good to me. Passing to @rspeicher. Could you please review? Thanks!

assigned to @rspeicher

@blackst0ne Please also retry the failed two jobs?

mentioned in issue #36782

Please also retry the failed two jobs?

Restarted.

@blackst0ne Minor nitpick in the spec organization. Thanks!

assigned to @blackst0ne

added 292 commits

• 7bdbdc8a...cdf87fe8 - 286 commits from branch gitlab-org:master
• 7a1c5ba7 - Add index on ci_runners.contacted_at
• 20479913 - Merge remote-tracking branch 'upstream/master'
• 0a61d648 - Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce
• 5af8ac8e - Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce
• 0f006dc0 - Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce
• a100bfd3 - Replace 'source/search_code.feature' spinach test with an rspec analog

Compare with previous version

resolved all discussions

@rspeicher I updated the code.

assigned to @rspeicher

@rspeicher I've restarted two failed builds, but it seems they're not related to the spinach specs.

@blackst0ne Two more nitpicks.

assigned to @blackst0ne

resolved all discussions

added 1 commit

• ec1ec9b6 - Replace 'source/search_code.feature' spinach test with an rspec analog

Compare with previous version

@rspeicher fixed.

assigned to @rspeicher

approved this merge request

@blackst0ne Great, thanks!

Failure is https://gitlab.com/gitlab-org/gitlab-ce/issues/34323, going to merge.

merged

mentioned in commit 7edeccfc

@blackst0ne Thanks!

mentioned in issue gitlab#6527