Skip to content
Snippets Groups Projects

Add user preference to view project activity and starred project activity as default dashboard

Merged Stan Hu requested to merge stanhu/gitlab-ce:add-activity-dashboard-preference into master

Screenshot:

image

Closes #2662 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I hadn't thought about it until looking at this, but this custom dashboard feature is kind of confusing now. It made sense to me when both options in the dropdown ("Your Projects", "Starred Projects") existed as root-level menu elements.

    But now the dashboard menu has "Projects" which contains "Your Projects" and "Starred Projects" as filters.

    Similarly, there's the "Activity" menu item which contains "Your Projects" and "Starred Projects" as filters.

    Maybe we should set the two options to "Project" and "Activity", and then remember which filter they select with a cookie or something.

    cc @dzaporozhets

  • @rspeicher I don't think its much confusing. You can add 2 activity options instead one: for your and starred projects.

    I don't like having mix of db setting and cookies. I would like same behavior between devices. Basically i always want to know which page i will see visiting root path.

  • @stanhu can you please add an option with activity for starred projects too? In this case it would be nicely balanced

  • Stan Hu Added 1 commit:

    Added 1 commit:

    • f7bd400f - Add user preference to view project activity and starred project activity as default dashboard
  • Stan Hu Title changed from Add user preference to view activities as default dashboard to Add user preference to view project activity and starred project activity as default dashboard

    Title changed from Add user preference to view activities as default dashboard to Add user preference to view project activity and starred project activity as default dashboard

  • Author Maintainer
  • @stanhu can you check specs?

  • Stan Hu Added 1 commit:

    Added 1 commit:

    • aa5c561e - Add user preference to view project activity and starred project activity as default dashboard
  • Author Maintainer

    Specs have been updated. Thanks!

  • Stan Hu Added 1 commit:

    Added 1 commit:

    • 0383afc6 - Add user preference to view project activity and starred project activity as default dashboard
  • username-removed-444 Status changed to merged

    Status changed to merged

  • mentioned in commit ac34ce86

  • Author Maintainer

    There seems to be a bug here. Now if the "Your Projects' Activity" selection is clicked, there is no way of seeing the list of projects available. It looks like we can fix this by only doing the redirect if the referral is blank.

    EDIT: A better way would be to link to the project page directly instead of the root page.

    Edited by Stan Hu
  • Stan Hu mentioned in merge request !1459 (merged)

    mentioned in merge request !1459 (merged)

  • Stan Hu mentioned in commit abae352e

    mentioned in commit abae352e

  • mentioned in commit 2e8a3e39

  • Stan Hu mentioned in issue #2655 (closed)

    mentioned in issue #2655 (closed)

  • Please register or sign in to reply
    Loading