Commits without .gitlab-ci.yml are marked as skipped

• Commits without .gitlab-ci.yml are marked as skipped
• Save detailed error when YAML syntax

This also fixes: #3521 (closed) #3546 (closed)

/cc @jacobvosmaer

Added 1 commit:

• 601b50f9 - Commits without .gitlab-ci.yml are marked as skipped

@ayufan so a MR button will just be green again, if there is no gitlab-ci.yml?

👍

@rspeicher this should go into stable I think

@jacobvosmaer

Added 32 commits:

• 601b50f9...a42d469a - 29 commits from branch master
• 2b907f61 - Commits without .gitlab-ci.yml are marked as skipped
• 0df7a32e - Fix tests
• fd6b5894 - Since GitLab CI is enabled by default, remove enabling it by pushing .gitlab-ci.yml

Makes sense since GitLab CI is enabled by default

👍

The red-ish button in @ayufan's screenshot does not look very neutral to me. More like GitLab is disapproving of merging the MR; it is the same color as the 'Merge' button for a MR with a failed build.

I don't think we should be sending the user a 'merging this is bad' signal.

@jacobvosmaer This is UI/UX thing and more like a job for @skyruler to figure out.

Added 1 commit:

• a5b10196 - Fix tests

Added 1 commit:

• 8248314b - Don't rescue Exception, but StandardError

mentioned in commit 0383f84d

Status changed to merged

mentioned in issue #3530 (closed)

Picked into 8-2-stable.

mentioned in commit 978f0bac

@ayufan How could I merge ci-yaml-validation into master,in issue 3546,you said it would be changed into skipped,so is the status of "skipped " correct?

@ayufan I assume that when a branch doesn't have a .gitlab-ci.yml file the accept merge request button is green, not red. Is this correct?

@sytses Currently if we don't have .gitlab-ci.yml and build is marked as skipped the image is as presented above:

mentioned in issue #3827 (closed)