Numerous UI improvements

Numerous UI improvements, in no particular order. Not split up into commits, but that can be arranged upon request.

• Properly position logo tooltip

  

• Restore sidebar tooltips

  

• Move project visibility status to the left + Add edit and RSS buttons to project home panel + Add visibility level description to snippet and project visibility labels

  

• Remove padding around form-actions

  

• Unify new project namespace select and path input

  

• Redesign multiple select2 options + Tweak style of select2 placeholders

  

• Add "New X" buttons to dashboard and group issue, MR and milestone indexes

  

• Move labels to second line of issue/MR list item

  

• Use new style for milestone detail page

  

• Use new style for wiki

  

• Use select2 for bulk issue edit status

• Move "Start new merge request" checkbox closer to New branch field

• Remove "none" username for "Unassigned" and "Any User" select options

• Add edit and RSS buttons to project home panel

• Use gl-padding instead of 10px/15px where appropriate

• Fix logo height in signed-out header bar

• Fix alignment of buttons in issue header

• Use gl-padding for panels

• Fix horizontal alignment of sidebar items when collapsed

• Fade in/out Back icon in sidebar

• Fix page title margin

• Use same text color for commit box as issue title

• Remove duplicated styling for center top menus

• Remove double border between gray blocks

• Add pointer cursor to award emoji selector

• Remove style duplication between snippet and issue detail pages

• Capitalize tab titles

• Prefer "Files" over "Code"

• Truncate submodule commit SHAs to 7 characters

• Add "No Milestone" option to issue milestone select

• Don't reset target branch when choosing to "Change branches" in MR

• Separate page title segments by middot rather than pipe

• Use "Assigned to USER" tooltip in issue list item

• Use "Any Label" and "Any Milestone" in selects rather than the ambiguous "Any" option

• Use consistent casing for page titles and form field labels

• Fix incorrect active state for "Your Projects" tab

• Don't use success state for explore projects search button

• Use form-actions where appropriate

• Use autofocus on title inputs where appropriate

• Use js-requires-input where appropriate

• Don't write "Optional" or "Required" unless non-obvious

• Add cancel button to forms that didn't have one already

• Add header title to import pages

• Use table-holder where appropriate

• Add plus icon to all "Add X" buttons

• Extract title from copy/pasted SSH key when it ends in a newline

• Fix padding of no readme and empty repo messages

• Use file-type specific file icon in blame view and diff item

• Move branch list info tags out of main link

• Use monospace font for commit SHA in branch list

• Only use input placeholders when they add value

• Add clipboard button to commit box SHA

• Move subscription info below label info in issue/MR sidebar

• Link issue/MR list item comments counter to comments

• Use "opened by" instead of "created by" in issue/MR header, like in list

• Use "Delete" in milestone and label delete buttons instead of "Remove"

• Link to branches from MR "Request to merge X into Y" sentence

• Move "Add Group" button higher up in new project form

• Only show "Manage group members" in project member list when user has access

• Don't use success state for "Download zip" button

• Add tooltip to tag list edit release notes button

• Make tree view "Add file" button smaller

• Add "New issue" link to dashboard/group milestone project-specific issue panels

• Move "Please review the contribition guide" next to MR/issue Submit button

• Use normal-styled tabs in profile view

• Make content only as tall as it needs to be

• Use full names in emoji tooltip

• Fix padding around editor path, input and select box.

• "CI build passed", not "CI build success"

Fixes #3544 (closed), #2928 (closed), #2882 (closed), #2071 (closed), #1425 (closed), #3742 (closed), https://dev.gitlab.org/gitlab/gitlabhq/issues/2594, https://dev.gitlab.org/gitlab/gitlabhq/issues/2590, https://dev.gitlab.org/gitlab/gitlabhq/issues/2589, https://dev.gitlab.org/gitlab/gitlabhq/issues/2581, https://dev.gitlab.org/gitlab/gitlabhq/issues/2577, https://dev.gitlab.org/gitlab/gitlabhq/issues/2575, https://dev.gitlab.org/gitlab/gitlabhq/issues/2573,

I feel like this is a lot for a single MR. 😃

@rspeicher I do too, but I didn't want to split it up in 60 MRs 😃 If there's anything that warrants more discussion, I'm happy to extract it and post a separate MR.

Added 1 commit:

• ae00091e - Use full names in emoji tooltip

@DouweM OMG this is amazing!!!

Use normal-styled tabs in profile view

@DouweM what do you mean?

Lol....This would utterly WRECK the CHANGELOG :o !

P.S. It would be great to get screenshot on most of changes to prevent surprises after merge

Also its scary that all changes in one commit. We can not pick/separate/revert certain changes. Because with so many changes I expect some things to break

Maybe you can also tackle #3742 (closed)

@dzaporozhets I basically did everything at the same time, and afterwards I made that list of changes. I’m happy to split it up a little bit more, this is obviously unreviewable, but I was just so happy to get it out the door 😜 More screenshots, will do.

@razer6 Seriously Robert, I change 186 files but you want more?

jk, will check it out.

haha :D Welcome to Robert's torture 😆
Everytime you think you're finished he'll find "just one more thing" 🙈

This is amazing, great work @DouweM

Added 1 commit:

• 08175e3b - Fix padding around editor path, input and select box.

Added 1 commit:

• 96b45411 - "CI build passed", not "CI build success"

Added 4 commits:

• 0c472796 - Fix spec
• 9446dad6 - Revert debugging change
• 2dfb6615 - "Browse Directory" > "Browse Dir"
• bd6305d8 - Fix specs

This commit message reversed the change order. Get your shit together, @DouweM!

Unless you meant that the new message is greater than the old one. Touche!

@rspeicher Lol, I can see how that may be confusing. But yeah, I meant "greater than".

@DouweM Nice job! More awesomeness for Gitlab is always good!

mentioned in merge request !1941 (closed)

As discussed with @dzaporozhets, I will split this MR up into a number of smaller MRs, with separate ones for “new” stuff and separate ones for things that are ​_really_​ only “fixing” inconsistent padding etc.

Everything in one MR was never gonna work, but I was too happy to be done with it and wanted all of your praise 😜 Next step is making it something that can be reviewed and merged in pieces. I hope to have time to split it up today or tomorrow, with screenshots of every UI change.

Status changed to closed

@DouweM Hooray!

@DouweM Wow!

Split up into:

• !1953 (merged) - UI: More consistent alignment and padding
• !1954 (merged) - UI: Improve consistency across the board
• !1955 (merged) - UI: Improve form consistency
• !1956 (merged) - UI: Miscellaneous tweaks
• !1957 (merged) - UI: Remove minimum container height
• !1958 (merged) - UI: Sidebar & header tweaks and fixes
• !1960 (merged) - UI: Award emoji tweaks
• !1961 (merged) - UI: Issuable form tweaks
• !1962 (merged) - UI: Issuable list item tweaks
• !1963 (merged) - UI: Issuable filter tweaks
• !1964 (merged) - UI: New Project form tweaks
• !1965 (merged) - UI: Project home panel tweaks
• !1966 (merged) - UI: Use new style for milestone detail page
• !1967 (merged) - UI: Use new style for wiki
• !1968 (merged) - UI: Add "New X" buttons to dashboard and group issue, MR and milestone indexes

15 merge requests, 93 commits, 198 changed files

That should put me above @rspeicher on https://gitlab.com/gitlab-org/gitlab-ce/graphs/master again.

@DouweM but not enough for http://contributors.gitlab.com/ 🚎

@DouweM awesome. I slowly review and merge it