Updated Rubocop to latest version

Version 0.28.x current in use is exactly 1 year old, and throws a lot of error messages when usign the atom editor integration plugin.

New version is compatible and adds many improvements and bugfixes. cc @DouweM @dzaporozhets

After running our code against rubocop, I can summarize the biggest offenders that we can disable while fixing the others:

# Offense count: 24
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

# Offense count: 104
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/ExtraSpacing:
  Enabled: false

# Offense count: 62
# Configuration parameters: EnforcedStyle, SupportedStyles.
Rails/TimeZone:
  Enabled: false

# Offense count: 14
# Configuration parameters: CountComments.
Metrics/ModuleLength:
  Max: 517

Initial analysis available here: https://gitlab.com/gitlab-org/gitlab-ce/builds/456332

Style/ExtraSpacing we'll want to enable AllowForAlignment, I do this a lot.

Added 3 commits:

• d1f1c5c6 - Updated .rubocop.yml to match 0.35.x changes
• b5291f95 - Fixed Rubocop offenses
• f479ed30 - Disabled Rails/Date cop

@rspeicher I initially opted to disable Style/ExtraSpacing completely, to reduce the amount of files touched by this MR.

If you believe we should put some effort on it, I can re-enable and run an autofix (and double check every change made after it).

@brodock Oh, no, that's fine. I guess I meant if we enable it...

Added 1 commit:

• 90720982 - Fixed CiServices validation

Reassigned to @dzaporozhets

all green :)

Status changed to merged

mentioned in commit 0d34cac7

mentioned in commit 200a9006

mentioned in commit 4f1b9295

mentioned in commit 5ceb85d6

mentioned in commit 91016eb6

mentioned in commit da13d1af

mentioned in commit f498569b

mentioned in commit 136df9f8