Import GitHub Pull Requests into GitLab

Fixes #2833 (closed)

Title changed from Import GitHub Pull Requests into GitLab to WIP: Import GitHub Pull Requests into GitLab

@DouweM I'll add the spec for the importer. Meanwhile, could you take a look?

/cc @dzaporozhets

Added 1 commit:

• c4f37eea - Refactoring GithubImport::Importer

Added 3 commits:

• 3142aaf6 - Import cross-project GitHub Pull Requests into GitLab
• 6da04dee - Generate separate comments when importing GitHub Issues into GitLab
• fdb18317 - Update CHANGELOG

Added 71 commits:

• fdb18317...1100eb0c - 70 commits from branch master
• ac6eb1a1 - Merge branch 'master' into import-gh-pull-requests

Title changed from WIP: Import GitHub Pull Requests into GitLab to Import GitHub Pull Requests into GitLab

Reassigned to @DouweM

Added 3 commits:

• ac6eb1a1...c75ac821 - 2 commits from branch master
• 4c76aa2e - Merge branch 'master' into import-gh-pull-requests

@dbalexandre If importing cross-project MRs is too much work, we can just skip that for now. Most people importing a GH project will be importing a private project with only same-project MRs.

Reassigned to @dbalexandre

Added 222 commits:

• 4c76aa2e...17ef4cdf - 214 commits from branch master
• 75c890d5 - Import GitHub Pull Requests into GitLab
• 672b5f07 - Import comments on GitHub Pull Request into GitLab
• 70535552 - Import comments on the diff of a GitHub Pull Request into GitLab
• 94554b80 - Doesn't import GitHub PR where branches were no longer available
• 15c25bd9 - Extract methods to import comments on a GitHub Pull Request
• 2d386b2e - Refactoring GithubImport::Importer
• 7e087c16 - Generate separate comments when importing GitHub Issues into GitLab
• e4d44901 - Update CHANGELOG

@DouweM The refs/pull/<pull request id>/head ref that that you mentioned, appears to be the better way to go for cross-project MRs. But we import the repo using the git clone --bare that doesn't maps all refs (including remote branches, notes etc.), and doesn't sets up a refspec configuration, and we remove the origin after we finish the importing process.

So, I think this will take more time that I imagined, and I'll skip it for now. Please, let me know if I'm doing something wrong.

Added 10 commits:

• e4d44901...47fbba44 - 2 commits from branch master
• 4c23d3d0 - Import GitHub Pull Requests into GitLab
• a83a8195 - Import comments on GitHub Pull Request into GitLab
• b3d8b5e6 - Import comments on the diff of a GitHub Pull Request into GitLab
• 8717dc23 - Doesn't import GitHub PR where branches were no longer available
• c7427831 - Extract methods to import comments on a GitHub Pull Request
• e2e6e13e - Refactoring GithubImport::Importer
• add1089b - Generate separate comments when importing GitHub Issues into GitLab
• 667b954c - Update CHANGELOG

Reassigned to @rspeicher

Reassigned to @DouweM

@dbalexandre Can we add a check to verify that we're only importing local pull requests? Also, can you expand the GitHub docs to mention we import pull requests, but not those from forks?

Reassigned to @dbalexandre

@DouweM sure!

Added 183 commits:

• 667b954c...8de1f715 - 173 commits from branch master
• 95f1fe72 - Import GitHub Pull Requests into GitLab
• 223f7f53 - Import comments on GitHub Pull Request into GitLab
• f19bf0ea - Import comments on the diff of a GitHub Pull Request into GitLab
• d72b2581 - Doesn't import GitHub PR where branches were no longer available
• 6c846ef8 - Extract methods to import comments on a GitHub Pull Request
• dc72a8b3 - Refactoring GithubImport::Importer
• 98909dd1 - Generate separate comments when importing GitHub Issues into GitLab
• 2dc74b48 - Update CHANGELOG
• 837a9065 - Ensure that we're only importing local pull requests
• e194b962 - Update doc for importing existing GitHub projects to GitLab

@DouweM MR updated. Could you take another look?

Reassigned to @DouweM

mentioned in commit 7884a261

Status changed to merged

Thanks @dbalexandre!

mentioned in issue gitlab-com/blog-posts#30 (closed)