Skip to content

Fix duplicated branch creation/deletion events when using Web UI

Stan Hu requested to merge stanhu/gitlab-ce:fix-duplicate-branch-activity into master

When deleting a branch, this is what was happening:

  1. DeleteBranchService calls EventCreateService and creates an event.
  2. The call to repository.rm_branch triggers the GitHooksService.
  3. This, in turn, calls GitPushService and then calls EventCreateService again.

5145706c now makes it no longer necessary for DeleteBranchService and CreateBranchService to create an event.

Closes #4304 (closed)

Merge request reports