fix #15127 ActiveJob::DeserializationError thrown

send_devise_notification pre-maturely enqueued the task when the user instance has not yet been committed into the database, causing a record-not-found in the other sidekiq process.

devise-async has already been taking care of asynchronous mail sending, we just need to run it inside queue mailers instead of mailer to enable it.

The implementation of devise-async enqueues the task in after_commit hook which is the right way to do it.

mentioned in issue #15127 (closed)

This sounds like a nice solution and simplifies other code that attempts to send notifications after commit.

@stanhu @rspeicher safe to merge?

@dzaporozhets Not sure, will leave to @stanhu.

Seems to work for me.

mentioned in commit 3656b5db

Status changed to merged

mentioned in commit d46e47a5

mentioned in merge request !4212 (merged)

mentioned in commit 52846d4b

Milestone changed to %8.9

Reassigned to @stanhu

@stanhu No action for you, just "bookkeeping".

FYI, had to revert this change due to fact that specs were failing. We should revisit this.

@stanhu Do we? config/initializers/devise_async.rb no longer exists in master, can't find the commit that removed it though.

Using git log -- config/initializers/devise_async.rb shows that file went away in d47b2b92. Also d46e47a5 reverted this change.

@stanhu @rspeicher I removed it with the devise-two-factor / devise 4 / attr_encrypted MR

!4216 (merged), replaced it with the Devise-included ActiveJob adapter.