Clean up unused routes
I tried to clean up the routes as mentioned in #14584 (closed)
I used the following script and manually verified the changes: https://gist.github.com/strzibny/4ccbda7dcf67ef6719dcb047014e1ea7
After this patch, the script still gives me the following routes:
Unused routes (7): oauth/authorizations#show doorkeeper/tokens#create doorkeeper/tokens#revoke oauth/applications#edit oauth/applications#show doorkeeper/token_info#show omniauth_callbacks#(?-mix:(?!))
Here is a relevant code from doorkeeper on drawing these routes: https://github.com/doorkeeper-gem/doorkeeper/blob/5ea4575863781940fe6996692c6b41f2ad71d90e/lib/doorkeeper/rails/routes.rb#L25
Merge request reports
Activity
Added ~164274 technical debt labels
cc: @rymai
330 328 end 331 329 end 332 330 resource :preferences, only: [:show, :update] 333 resources :keys 331 resources :keys, only: [:index, :show, :new, :create, :destroy] @strzibny You're right, let's keep
only:
, even though it's very unlikely that Rails will add new default actions! ;)
@strzibny Thanks so much! Could you please rebase, address my comment, and add a CHANGELOG entry under 8.10? Thanks in advance!
Milestone changed to %8.10
Reassigned to @rymai
Added 3856 commits:
-
b0be3cf2...ea6e4bf0 - 3855 commits from branch
gitlab-org:master
- 9e5e8b4f - Clean up unused routes
-
b0be3cf2...ea6e4bf0 - 3855 commits from branch
@strzibny Thanks! Could you please retry the failing builds? Thanks!
@strzibny Also, please add a CHANGELOG entry. ;)
Milestone changed to %8.11
mentioned in merge request !5499 (merged)
Closing in favor of !5499 (merged). Thanks @strzibny!!!
mentioned in commit 260102b2