WIP: #17467 Included the possibility of a permissions issue in 404 error messages
What does this MR do?
- Adds the possibility of a permissions issue to the 404 error message, as well as its accompanied solution suggestion.
- Allows 404 page layout to be responsive.
Are there points in the code the reviewer needs to double check?
Should the other statically served error pages be responsive?
Why was this MR needed?
Users with incorrect permissions should not just be told the resource could not be found but also malicious users should not know exactly when and where they need elevated permissions.
What are the relevant issue numbers?
Fixes #17467 (moved).
Screenshots (if relevant)
UPDATE:
Merge request reports
Activity
/cc @jschatz1
Added 233 commits:
-
70ca47f4...f26389a0 - 232 commits from branch
gitlab-org:master - 82f7ca91 - Extended the current error message and suggestion message to include the possibi…
-
70ca47f4...f26389a0 - 232 commits from branch
Added frontend label
Reassigned to @jschatz1
Added 54 commits:
- 82f7ca91...98b1daf3 - 53 commits from branch
gitlab-org:master - 8420c13d - Extended the current error message and suggestion message to include the possibi…
- 82f7ca91...98b1daf3 - 53 commits from branch
-
@jvanbaarsen Rebased
Last reply by username-removed-1164
@LukeeeeBennett I believe this was done on purpose. To give as little information as possible. If they don't have permission it was most likely on purpose. I do like the more ambiguous but also truthful "This is not the webpage you are looking for."
It's a little old but maybe we can come up with a sentence that is both truthful but more ambiguous. I think the 404 should also be simple. There is no reason we can't tell them in 1 sentence what's happening. Keep it simple right?
-
@jschatz1 I completely agree and have been thinking up a cool git-related alternative for a while now and it's starting to hurt my brain. Turn on the bat-signal for the uber-creatives!
Edited by Luke "Jared" Bennett Added 460 commits:
- 8420c13d...4581e71c - 459 commits from branch
gitlab-org:master - af523602 - Extended the current error message and suggestion message to include the possibi…
- 8420c13d...4581e71c - 459 commits from branch
Added 26 commits:
- af523602...0f96a6c2 - 25 commits from branch
gitlab-org:master - 771f283b - Extended the current error message and suggestion message to include the possibi…
- af523602...0f96a6c2 - 25 commits from branch
Reassigned to @jschatz1
Added 45 commits:
- f3c2c75f...e6389dfe - 44 commits from branch
gitlab-org:master - 8152d880 - Extended the current error message and suggestion message to include the possibi…
- f3c2c75f...e6389dfe - 44 commits from branch
-
@lbennett let's not mention permissions.
How about
We are really sorry but the page your requested cannot be found.
Reassigned to @lbennett
-
@jschatz1 As the sub text?
Reassigned to @jschatz1
Reassigned to @lbennett
-
| ]-----• [ |
Edited by Luke "Jared" Bennett Milestone changed to %8.10
I'm interested to see what you finally settle on @jschatz1 and @lbennett. I agree we don't want to reveal too much but I think it's acceptable to give the indication that either this resource doesn't exist or you don't have permission. The problem is that saying 'not found' only leaves people really confused when they know it's there - maybe someone gave them a link. Having a bit more descriptive verbiage doesn't leak information as long as we're giving the same message for all cases.
-
@dblessing @jschatz1 and I are trying out something cool for this but I'll keep this in mind as we will still need a little text, I might see if I can get any more of it done and into the MR tonight :D
-
@lbennett looking forward to your MR
Milestone changed to %8.11
Milestone changed to %8.13
-
Just realised I never pushed my cool changes and have since reinstalled GDK a number of times, DOH.
I should redo this for %8.13 and get it off my MR's list :3
