Skip to content
Snippets Groups Projects

Add notification_settings API calls

What does this MR do?

It adds API calls to get/update notification settings, globally and at the group/project level.

Are there points in the code the reviewer needs to double check?

None

Why was this MR needed?

Notification settings were updated, but related API calls were never created.

What are the relevant issue numbers?

gitlab-org/gitlab-ce#19359

Does this MR meet the acceptance criteria?

Closes #19359 (closed)

Merge request reports

Pipeline #4199502 passed

Pipeline passed on mahcsig:19359-api-for-notification-settings

Merged by avatar (Apr 24, 2025 8:14am UTC)

Loading

Pipeline #4216669 passed

Pipeline passed for 3a59efd5 on master

Test coverage 90.79% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-128633 Added ~164274 ~13884 labels

    Added ~164274 ~13884 labels

  • @mahcsig re: docs.

    • Add a period at then end of each sentence that describes the method (the opening sentence of each section).
    • Make the description for enabling the notifications read like "Enable/disable this notification"
    • Use long options for curl example as per the new guidelines introduced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5703

    And of course, thanks for adding comprehensive documentation :heart:

    Edited by Achilleas Pipinellis
  • Added 481 commits:

  • Added 15 commits:

  • @rspeicher MR number has been updated. :smiley: Just waiting for milestone assignment to update that one as well.

    @zj :thumbsup:

    @rymai Updated to use grape function, didn't know about that one, good call. I also updated params to use the array from the model so any new ones added are automatically part of the api. Doc changes will still need to be made manually though.

    @axil Updated the docs as requested.

    Thanks to all for looking at this. :smiley:

    There was one test that failed, but it was unrelated to this MR.

    Edited by username-removed-551606
  • Added 934 commits:

  • @rymai rebased and all test are passing again.

  • username-removed-551606 Resolved all discussions

    Resolved all discussions

  • @rymai does the updated code look good?

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading