Fix error 500 on Runners page.
What does this MR do?
Fixes error 500 on Runners page (ActionView::Template::Error (Missing partial kaminari/_paginator
)
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
What are the relevant issue numbers?
No GitLab issue; originally reported downstream: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819903
Screenshots (if relevant)
N/A
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together
Merge request reports
Activity
@onlyjob Thanks for contributing back to GitLab, but I'm not sure this is an issue. I can reproduce. Can you provide steps to reproduce the problem this MR is trying to fix?
There is a problem, there is no doubts about it. ;) Description says it all: access "Runners" page and it crashes with error 500 on server side. I've experienced it myself (see https://git.fosscommunity.in/debian-ruby/TaskTracker/issues/107) and it was reported in Debian by Libor Klepáč who also provided a patch. I've tested (and corrected) his patch so I'm confident that it fixes the problem. Since all tests are passed I believe it should be safe to merge. Problem was spotted on official Debian package.
@onlyjob The last comment on https://git.fosscommunity.in/debian-ruby/TaskTracker/issues/107 says it's been fixed in 8.10.5. Do you confirm?
@onlyjob Hmm, ok it seems that it's been fixed in https://anonscm.debian.org/cgit/pkg-ruby-extras/gitlab.git/tree/debian/patches/runners.patch but the fix needs to be merged upstream (here). The fix looks good to me, I'm wondering why we don't just set the
gitlab
theme as the default, though...Thanks @onlyjob!
Milestone changed to %8.13
Reassigned to @rymai
Mentioned in commit 434ad2b9
Mentioned in commit 4265ba84