Fixed enter key in search input not working
What does this MR do?
Fixes a bug where the enter key wouldn't search in the top nav search input
Closes #20627 (closed)
Merge request reports
Activity
mentioned in issue #20946 (closed)
Added 77 commits:
-
25a3bf76...cd102716 - 76 commits from branch
master
- 88c74c74 - Fixed enter key in search input not working
-
25a3bf76...cd102716 - 76 commits from branch
@iamphill can you please resolve the conflicts and ping me once this is ready?
Added 123 commits:
-
88c74c74...fb84439a - 122 commits from branch
master
- 62bd837d - Fixed enter key in search input not working
-
88c74c74...fb84439a - 122 commits from branch
@rdavila conflicts sorted.
Added 1 commit:
- 64500240 - Fixed enter key in search input not working
Added 1 commit:
- 2bddf8e2 - Allow passing an index to selectRowAtIndex
Added 1 commit:
- 2bddf8e2 - Allow passing an index to selectRowAtIndex
Reassigned to @jschatz1
mentioned in issue #21267 (closed)
613 618 614 619 GitLabDropdown.prototype.selectRowAtIndex = function(index) { 615 620 var $el, selector; 616 selector = SELECTABLE_CLASSES + ":eq(" + index + ") a"; 621 // If we pass an option index 622 if (index !== undefined) { 623 selector = SELECTABLE_CLASSES + ":eq(" + index + ") a"; 624 } else { 625 selector = ".dropdown-content .is-focused"; 626 } 617 627 if (this.dropdown.find(".dropdown-toggle-page").length) { 618 628 selector = ".dropdown-page-one " + selector; 619 629 } 620 630 $el = $(selector, this.dropdown); 621 631 if ($el.length) { 622 $el.first().trigger('click'); 623 632 var href = $el.attr('href'); 624 if (href && href !== '#') Turbolinks.visit(href); 633 if (href && href !== '#') { 634 Turbolinks.visit(href); 635 } else { 636 $el.first().trigger('click'); Added 46 commits:
-
2bddf8e2...f633f7db - 44 commits from branch
master
- 59632639 - Fixed enter key in search input not working
- 86f03e17 - Allow passing an index to selectRowAtIndex
-
2bddf8e2...f633f7db - 44 commits from branch
Enabled an automatic merge when the build for 86f03e17 succeeds
mentioned in commit 9b079219
mentioned in issue #21279 (closed)
@smcgivern good call, I'm going to add it
mentioned in commit e6f5653c
mentioned in issue #21180 (closed)
mentioned in issue #21377 (closed)
mentioned in issue #21390 (closed)
mentioned in issue #21401 (closed)
mentioned in issue #21409 (closed)
Mentioned in commit pfjason/gitlab-ce@9b079219
Mentioned in commit nick.thomas/gitlab-ee@e6f5653c