Updated diff toggle targets and added icon
What does this MR do?
Adds the new diff toggle icon and alters the toggle targets.
User can now click on the file header bar (where no other elements are above it, apart from the icon) and the Click to expand link to expand the diff and no where else.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Gif
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if you do - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #21369 (closed)
Closes #20326 (closed)
Merge request reports
Merged by
(Apr 15, 2025 5:45pm UTC)
Activity
Added 83 commits:
-
76b4fa43...2aaab34b - 81 commits from branch
master - ffdccaa0 - Updated diff toggle targets and added icon
- 40c7ba01 - Updated spec with next click targets
-
76b4fa43...2aaab34b - 81 commits from branch
Reassigned to @fatihacet
Reassigned to @jschatz1
42 47 } else if (this.content) { 43 48 this.collapsedContent.hide(); 44 49 this.content.show(); 50 this.$toggleIcon.addClass('fa-caret-down').removeClass('fa-caret-right'); 
@maxehnert I prefer to hard defined
addClassandremoveClass, it makes it less susceptible to small UI bugs, we've fixed a few recently because of this. There are some specific scenarios wheretoggleClassworks really well and saves a lot of lines.Happy to change this to
toggleClassif reviewers disagree with me :)
@lbennett you got some good comments here. Can you fix them?
Reassigned to @lbennett
Reassigned to @jschatz1
Milestone changed to %8.13
-
@lbennett One comment. Fix up and let me know.
Reassigned to @lbennett
Mentioned in commit 964d1bb1
Mentioned in issue #20327 (moved)
