Skip to content

WIP: Fix label filter dropdown edge cases

What does this MR do?

Specifically encode ' rather than encoding all characters as the frontend and ruby encodes characters differently

Are there points in the code the reviewer needs to double check?

Check for any edge cases that this may not work

Why was this MR needed?

Fixes the following bugs:

  • Removing a filter label that contained a space did not get removed from the filter because the space was getting converted into %20
  • Double encoding occurs when filtering tags containing spaces in the Issues listing

Screenshots (if relevant)

Before: Screen_Shot_2016-09-07_at_3.21.59_PM

After: Screen_Shot_2016-09-07_at_3.22.59_PM

Before (removing filter label containing space): Screen_Shot_2016-09-07_at_3.24.17_PM

After (removing filter label containing space): Screen_Shot_2016-09-07_at_3.23.56_PM

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #21880 (closed), #21935 (closed)

Merge request reports