New `Members::ApproveAccessRequestService`
1 unresolved thread
1 unresolved thread
Part of #21979 (closed).
Does this MR meet the acceptance criteria?
-
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together
Merge request reports
Activity
mentioned in issue #21979 (closed)
mentioned in merge request !6269 (merged)
Added 1 commit:
- 228aeaf2 - Ensure Members::ApproveAccessRequestService can fin a requester by ID
Added 111 commits:
-
228aeaf2...1eeb92a5 - 109 commits from branch
master
- 89b4f12d - New Members::ApproveAccessRequestService
- 65581360 - Ensure Members::ApproveAccessRequestService can fin a requester by ID
-
228aeaf2...1eeb92a5 - 109 commits from branch
Added 111 commits:
-
228aeaf2...1eeb92a5 - 109 commits from branch
master
- 89b4f12d - New Members::ApproveAccessRequestService
- 65581360 - Ensure Members::ApproveAccessRequestService can fin a requester by ID
-
228aeaf2...1eeb92a5 - 109 commits from branch
Reassigned to @DouweM
@DouweM or @rspeicher Could you review?
Milestone changed to %8.13
@rspeicher Sure thing!
2 class ApproveAccessRequestService < BaseService 3 include MembersHelper 4 5 attr_accessor :source 6 7 def initialize(source, current_user, params = {}) 8 @source = source 9 @current_user = current_user 10 @params = params 11 end 12 13 def execute 14 condition = params[:user_id] ? { user_id: params[:user_id] } : { id: params[:id] } 15 access_requester = source.requesters.find_by!(condition) 16 17 raise Gitlab::Access::AccessDeniedError if cannot_update_access_requester?(access_requester) @rymai One note, LGTM.
Added 596 commits:
-
65581360...8071dc83 - 593 commits from branch
master
- b3f0a82f - New Members::ApproveAccessRequestService
- 5dcdf1d5 - Ensure Members::ApproveAccessRequestService can fin a requester by ID
- 94996963 - Inverse condition in Members::ApproveAccessRequestService
Toggle commit list-
65581360...8071dc83 - 593 commits from branch
Mentioned in commit 166c6cd8
Mentioned in merge request !6269 (merged)
Mentioned in commit 8a96910c
Please register or sign in to reply