WIP: Show commit messages in issues
What does this MR do?
Displays the full, rendered commit message below "Mentioned in commit af12af" system notes on the issue page.
Are there points in the code the reviewer needs to double check?
The use of javascript is not ideal, but it's an easy way to control when and where this extra content will show while loading the data through Banzai, which seems like a much simpler initial fix than restructuring other code, perhaps right back to SystemNoteService.cross_reference, to make this data available in the note itself.
This feature may need a project option or per-issue silence button because in some situations commit messages may be long or an issue may be mentioned in passing far too much. A text collapse control that limits the block initially visible to a few lines may also help with this, at the cost of making some information less visible again.
Why was this MR needed?
The commit messages often have crucial information regarding the progress of work against an issue and other commentary of interest when reading an issue, and, although the commit titles are available in a tooltip, this information is not currently visible enough.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if you do - rebase it please) -
Squashed related commits together