Skip to content
Snippets Groups Projects

Extract project#update_merge_requests to its own worker from GitPushService

Merged Paco Guzman requested to merge 15463-extract-update-merge-requests into master

What does this MR do?

Extract project#update_merge_requests to its own worker from GitPushService

I'd discarded to extract more code from the current GitPushService#update_merge_requests method because I think the other parts of that method are not related with the updating of merge requests they are more related with hooks, and I think we can extract that from both services (GitPushService and GitTagPushService) to the same place in other PR

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Relates to #15463 (moved)

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#15463 (moved)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Milestone changed to %8.13

  • Added ~18308 label

  • Paco Guzman Added 1 commit:

    Added 1 commit:

    • 9e7c8f28 - Extract project#update_merge_requests to its own worker from GitPushService
  • Paco Guzman Added 1 commit:

    Added 1 commit:

    • 1ae1d6ec - Extract project#update_merge_requests and SystemHooks to its own worker from GitPushService
  • Paco Guzman Added 67 commits:

    Added 67 commits:

    • 1ae1d6ec...73adae0f - 66 commits from branch master
    • d6632bdb - Extract project#update_merge_requests and SystemHooks to its own worker from GitPushService
  • yorickpeterse-staging Resolved all discussions

    Resolved all discussions

  • Paco Guzman Added 96 commits:

    Added 96 commits:

    • d6632bdb...a0f9cff5 - 95 commits from branch master
    • 44737c94 - Extract project#update_merge_requests and SystemHooks to its own worker from GitPushService
  • Paco Guzman Added 1 commit:

    Added 1 commit:

    • b981e0dc - Extract project#update_merge_requests and SystemHooks to its own worker from GitPushService
  • Paco Guzman Added 46 commits:

    Added 46 commits:

    • b981e0dc...23a2a8ef - 45 commits from branch master
    • 7ee6a0f4 - Extract project#update_merge_requests and SystemHooks to its own worker from GitPushService
  • Paco Guzman Added 1 commit:

    Added 1 commit:

    • 97c31d93 - Ensure a deterministic global state on Gitlab::Shell specs
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading