Grapify tags API
What does this MR do?
Add the Grape-DSL to the tags API.
Are there points in the code the reviewer needs to double check?
The delete endpoint only has a description but no success entity because we don't have one. We only return the branch name as JSON. Should I do something else?
What are the relevant issue numbers?
Related to #22928 (moved)
Merge request reports
Activity
- Resolved by username-removed-2900
- Resolved by username-removed-2900
- Resolved by username-removed-2900
@zj Thanks for the review!
Added 1 commit:
- 1feb3a98 - Grapify tags API
- Resolved by username-removed-2900
- Resolved by username-removed-2900
- Resolved by username-removed-2900
- Resolved by username-removed-2900
Thanks @razer6! I think you can use
params
directly in all the cases (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6860#note_16922017), I will document that.Mentioned in merge request !6864 (merged)
Reassigned to @razer6
@rymai I think there might be an exception when to use the
declared
. The declared function will include also non-provided optional parameters. When directly usingparams
one need to add default values if if required and not provided. https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6860/diffs#4d2b41cc4f7ece7025b7f08c9c9a27fc8f6bf642_44_45 is for example such a case. The declared ensures with the defaultinclude_missing: true
that message is always provided.Added 1 commit:
- c921f452 - Grapify tags API
Reassigned to @rymai
Mentioned in issue #22928 (moved)
Milestone changed to %8.14
- Resolved by username-removed-2900
Thanks @razer6, one nitpick!
Added backstage label
Reassigned to @razer6
Mentioned in commit 65d86e0d
Reassigned to @felipe_artur
Reassigned to @rymai
@rymai Thanks for looking into this. I updated the MR.
Thanks @razer6!
Mentioned in commit 3c270ab3
mentioned in issue gitlab#6486