Skip to content
Snippets Groups Projects

Grapify tags API

Merged username-removed-2900 requested to merge grapify-tags into master
All threads resolved!

What does this MR do?

Add the Grape-DSL to the tags API.

Are there points in the code the reviewer needs to double check?

The delete endpoint only has a description but no success entity because we don't have one. We only return the branch name as JSON. Should I do something else?

What are the relevant issue numbers?

Related to #22928 (moved)

Merge request reports

Pipeline #4751830 passed

Pipeline passed for 9c3b24ed on grapify-tags

Test coverage 89.07% (0.01%) from 1 job

Merged by avatar (Apr 6, 2025 9:41am UTC)

Loading

Pipeline #4756761 passed with warnings

Pipeline passed with warnings for 3c270ab3 on master

Test coverage 89.42% (0.01%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @zj Thanks for the review!

  • Added 1 commit:

  • Thanks @razer6! I think you can use params directly in all the cases (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6860#note_16922017), I will document that.

  • Mentioned in merge request !6864 (merged)

  • Reassigned to @razer6

  • @rymai I think there might be an exception when to use the declared. The declared function will include also non-provided optional parameters. When directly using params one need to add default values if if required and not provided. https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6860/diffs#4d2b41cc4f7ece7025b7f08c9c9a27fc8f6bf642_44_45 is for example such a case. The declared ensures with the default include_missing: true that message is always provided.

  • Added 1 commit:

  • username-removed-2900 Resolved all discussions

    Resolved all discussions

  • Reassigned to @rymai

  • Mentioned in issue #22928 (moved)

  • Milestone changed to %8.14

  • Thanks @razer6, one nitpick!

  • Reassigned to @razer6

  • Robert Speicher Mentioned in commit 65d86e0d

    Mentioned in commit 65d86e0d

  • username-removed-2900 Resolved all discussions

    Resolved all discussions

  • Reassigned to @rymai

  • @rymai Thanks for looking into this. I updated the MR.

  • Added 1 commit:

    Compare with previous version

  • username-removed-2900 Resolved all discussions

    Resolved all discussions

  • username-removed-128633 Status changed to merged

    Status changed to merged

  • Mentioned in commit 3c270ab3

  • mentioned in issue gitlab#6486

  • Please register or sign in to reply
    Loading