Skip to content
Snippets Groups Projects

Use to_h to convert params to a hash

Merged username-removed-2900 requested to merge grapify-to-h into master

@rymai There are other places in the API, which does not use to_h but directly feeds the Hashie::Mash to a service. Shall we update those as well?

Merge request reports

Pipeline #4981098 passed with warnings

Pipeline passed with warnings for 510092c8 on grapify-to-h

Test coverage 89.57% from 1 job
Approval is optional

Merged by username-removed-128633username-removed-128633 8 years ago (Nov 14, 2016 1:16pm UTC)

Merge details

  • Changes merged into master with 36fa5d66.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #4983251 passed

Pipeline passed for 36fa5d66 on master

Test coverage 89.71% from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Stan Hu Reassigned to @razer6

    Reassigned to @razer6

  • Added 1 commit:

    • d12cd03a - Use #to_h to convert params to a hash

    Compare with previous version

  • username-removed-2900 Resolved all discussions

    Resolved all discussions

  • @stanhu I added a helper. For now only the milestones API uses this helper but other APIs should be refactored to do the same. But this is out of scope of this MR.

  • Reassigned to @razer6

  • username-removed-2900 Resolved all discussions

    Resolved all discussions

  • Added 1 commit:

    • 510092c8 - Use #to_h to convert params to a hash

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading