Skip to content
Snippets Groups Projects

Pass commit data to ProcessCommitWorker

Merged yorickpeterse-staging requested to merge process-commit-worker-improvements into master
All threads resolved!

This changes ProcessCommitWorker so that it takes a Hash containing commit data instead of a commit SHA. This means the worker doesn't have to access Git just to process a commit message (and other data it may use). This in turn should solve the problem of ending up with 15 000-something jobs in the process_commit queue that take forever to process.

Merge request reports

Pipeline #5214633 passed

Pipeline passed for 6b4d3356 on process-commit-worker-improvements

Test coverage 90.44% from 1 job
Approval is optional

Merged by Douwe MaanDouwe Maan 8 years ago (Dec 2, 2016 4:32am UTC)

Merge details

  • Changes merged into master with ec4e7d9a.
  • Deleted the source branch.

Pipeline #5224923 passed with warnings

Pipeline passed with warnings for ec4e7d9a on master

Test coverage 90.47% from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @yorickpeterse Changelog item please!

  • Added 112 commits:

    Compare with previous version

  • Reassigned to @DouweM

  • Added 198 commits:

    Compare with previous version

  • yorickpeterse-staging Resolved all discussions

    Resolved all discussions

  • Reassigned to @DouweM

  • merged

  • Douwe Maan mentioned in commit ec4e7d9a

    mentioned in commit ec4e7d9a

  • Picked into 8-14-stable. Will go into 8.14.3.

  • username-removed-367626 removed ~149423 label

    removed ~149423 label

  • Douwe Maan mentioned in commit c16a5701

    mentioned in commit c16a5701

  • mentioned in commit 897bca62

  • If your commit data contains invalid utf-8 characters then the migration fails at JSON.dump(payload), the linux kernel contains such commits.

  • git does have encoding associated with (such( commits. just nobody thinks commits are nowadays non-utf8 :)

    so data should be converted to utf-8 from source encoding.

  • Please register or sign in to reply
    Loading