Nested groups feature improvemetns

What does this MR do?

• Refactor and rename some methods for Namespace class
• Adds new methods to user model
• Includes nested projects in RefreshAuthorizedProjectsService

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Make code better and integrate nested groups more deeply

Screenshots (if relevant)

no

Does this MR meet the acceptance criteria?

• Changelog entry added
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/2772

restored source branch dz-nested-groups-access-improvements

added 1 commit

• f4d6b5c7 - Refactor Namespace code related to nested groups

Compare with previous version

added 2 commits

• aee21eff - Refactor Namespace code related to nested groups
• 95847588 - Add User#nested_groups and User#nested_projects methods

Compare with previous version

unmarked as a Work In Progress

changed title from WIP Add User#nested_groups method to Nested groups feature improvemetns

marked as a Work In Progress

added 94 commits

• 95847588...e553c3b4 - 92 commits from branch master
• 8ae985d8 - Refactor Namespace code related to nested groups
• 429bb00a - Add User#nested_groups and User#nested_projects methods

Compare with previous version

added 94 commits

• 95847588...e553c3b4 - 92 commits from branch master
• 8ae985d8 - Refactor Namespace code related to nested groups
• 429bb00a - Add User#nested_groups and User#nested_projects methods

Compare with previous version

added 695 commits

• 429bb00a...4b43126d - 693 commits from branch master
• 51c4b20c - Refactor Namespace code related to nested groups
• 83f0de3d - Add User#nested_groups and User#nested_projects methods

Compare with previous version

added 1 commit

• 93e60696 - Add User#nested_groups and User#nested_projects methods

Compare with previous version

changed milestone to %8.17

added 1 commit

• 3a104eae - Add User#nested_groups and User#nested_projects methods

Compare with previous version

@smcgivern please review

marked the task Added for this feature/bug as completed

marked the task All builds are passing as completed

marked the task Conform by the merge request performance guides as completed

marked the task Conform by the style guides as completed

marked the task Squashed related commits together as completed

unmarked as a Work In Progress

marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

assigned to @smcgivern

@dzaporozhets first review done!

assigned to @dzaporozhets

added 1 commit

• baafb6a8 - Add User#nested_groups and User#nested_projects methods

Compare with previous version

resolved all discussions

resolved all discussions

@smcgivern thank you for quick review. Ready for second one

assigned to @smcgivern

@smcgivern polite ping

@dzaporozhets sorry, I finally got there! My comments are just questions as I try to get my head around this!

assigned to @dzaporozhets

@smcgivern all questions answered. Waiting for more feedback.

@yorickpeterse can you please take a look at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8448#note_21941315 soon? I believe this is a last question blocking this MR

added 1 commit

• f98273af - Add User#nested_groups and User#nested_projects methods

Compare with previous version

added 1 commit

• 52c5f9c9 - Add User#nested_groups and User#nested_projects methods

Compare with previous version

enabled an automatic merge when the pipeline for 52c5f9c9 succeeds

resolved all discussions

resolved all discussions

merged

mentioned in commit 8a9597fc

mentioned in merge request !10885 (merged)