Adding links to user & build stage in a Build message
What does this MR do?
Adds links to commit author and build stage in slack notifications
- Build the
author_url
and send it as part of the build message- If the author is a GitLab user,
author_url
is the GitLab user's url - else it is the
mailto
ref. of theauthor_email
fromgit
- If the author is a GitLab user,
- Use the build_id & author_url to construct links to the build & author
Are there points in the code the reviewer needs to double check?
- The location of where the author_url should be constructed. Was not sure if the
data_builder/build.rb
file is the correct place
Why was this MR needed?
For giving additional information about builds in slack notifications
Screenshots (if relevant)
Before:
After:
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #26500 (closed)
Partially addresses #21114 (moved)
Merge request reports
Activity
@mpoornima Thank you very much for your contribution!
💯 - Resolved by username-removed-804460
- Resolved by username-removed-378947
- Resolved by username-removed-804460
- Resolved by username-removed-804460
/cc @grzesiek
I'm not sure if the fallback to
mailto:
link makes sense. It may be a little bit unexpected that sometimes clicking the link opens your browser and sometimes email client. Maybe we can get some UX help.added 1 commit
- 8e46fe2d - Modifying changelog entry to add merge request id
mentioned in issue #27149 (moved)
Thoughts on this @dimitrieh? Thanks!
😄 This seems great, i think the fallback to mailto: is sort of integrated with git.. and is imo the way to handle this.. (we do this in some places within gitlab it self as already).. just an extra thought towards this.. wouldn't it be even more useful to get linked to a 1:1 chat if that person is a gitlab user and also a mattermost user?
@adamniedzielski @mpoornima just to be sure.. we are speaking about a single build, not a whole "stage" correct? in that sense perhaps adjust the wording?
@pedroms including you in this, as you did work on chatops previously, what do you think about the fallback to mailto: ?
@dimitrieh Thank you for your comments. Will change the wording.
added 339 commits
-
8e46fe2d...1138afe7 - 338 commits from branch
gitlab-org:master
- 467d552e - Adding links to user & build in Chat Notifications
-
8e46fe2d...1138afe7 - 338 commits from branch
wouldn't it be even more useful to get linked to a 1:1 chat if that person is a gitlab user and also a mattermost user?
I agree that it would be even more useful, but:
- I think that this notification is used both for Slack and Mattermost
- Even for Mattermost I'm not sure if we have the necessary information to do that
- It would make this MR more difficult
So I believe that we should stick to what is currently suggested. I'm fine with
mailto:
if you say so😄 .@mpoornima The build failure doesn't seem to be related to your changes. I believe that we are already aware of the failing specs and it is already fixed in master or will be fixed soon.
changed milestone to %8.17
- Resolved by username-removed-804460