Added UX improvements to the project members settings view
What does this MR do?
Truncates the project title on really long titles in the panel header for the project members list Adds a description to non project owners or masters in the left column
Are there points in the code the reviewer needs to double check?
None at the moment
Why was this MR needed?
To improve the UX of the project members settings view
Screenshots (if relevant)
Before
Description to non project owners or masters
Long titles move things around in the panel header
After
Description to non project owners or masters
Truncated title after a set limit of 18 characters
Does this MR meet the acceptance criteria?
-
Changelog entry added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #26883 (closed)
EE Port
Merge request reports
Activity
cc @pedroms
assigned to @annabeldunstone
@annabeldunstone Can you review when you get a chance? Thanks!
added 1 commit
- 7151fa2c - Added a description for non project masters or owners for the members settings page
@jivanvl this looks good to me! Just a note about truncation
assigned to @jivanvl
changed milestone to %8.17
added 1 commit
- 56c3e304 - Changed the way to truncate the panel to title from ruby to a scss mixin
added 1 commit
- 1a982052 - Changed the way to truncate the panel to title from ruby to a scss mixin
assigned to @annabeldunstone
@annabeldunstone Improved the MR based on your observations
-
@jivanvl awesome! Just have a couple notes. I think truncating is the way to go here, but at the moment it's truncating when there's a ton of space in the header. Couldn't we go full-width at a certain point?
assigned to @jivanvl
added 445 commits
-
1a982052...9eb39dde - 442 commits from branch
master - 7690f16a - Added a description for non project masters or owners for the members settings page
- b925d727 - Changed the way to truncate the panel to title from ruby to a scss mixin
- b20531aa - Added a media query when there's a more width available to show more of the title
Toggle commit list-
1a982052...9eb39dde - 442 commits from branch
assigned to @annabeldunstone
-
@jivanvl right, but we shouldn't be truncating text if there's plenty of room left. Something like this might work well https://css-tricks.com/flexbox-truncated-text/. @filipa did something similar here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8707/diffs#616b98655b9e00d7e852dd5771060f443cac9ebe
assigned to @jivanvl
