Filter todos by manual add
Merged
Filter todos by manual add
1 unresolved thread
1 unresolved thread
What does this MR do?
Adds the option to filter todos by Added (Marked) and Pipelines (Build failed)
Are there points in the code the reviewer needs to double check?
No
Why was this MR needed?
For issue #26705 (closed)
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #26705 (closed)
Merge request reports
Activity
marked the task Changelog entry added as completed
marked the task Conform by the merge request performance guides as completed
marked the task Conform by the style guides as completed
marked the task Squashed related commits together as completed
mentioned in issue #26705 (closed)
This is for issue #26705 (closed)
108 127 109 expect(find('.todos-list')).to have_content ' assigned you ' 110 expect(find('.todos-list')).not_to have_content ' mentioned ' 128 expect_to_see_action(:build_failed) 129 end 130 131 def filter_action(name) 132 click_button 'Action' 133 within '.dropdown-menu-action' do 134 click_link name 135 end 136 137 wait_for_ajax 138 end 139 140 def expect_to_see_action(action_name) -
@jacopo-beschi Thank you, looks good to me!
changed milestone to %9.0
assigned to @smcgivern
LGTM, thanks @jacopo-beschi!
mentioned in commit 4c8a1d3a
@smcgivern Thank you for your support!
Please register or sign in to reply