Skip to content
Snippets Groups Projects

Update Rubocop to Ruby 2.3

Merged Zeger-Jan van de Weg requested to merge zj-drop-ruby-21-tests into master
All threads resolved!

FYI: We cannot merge this before the new stable branch has been cut.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-128633 resolved all discussions

    resolved all discussions

  • And I agree with @rspeicher that the refactorings from this MR should go in a dedicated MR. Only the Ruby 2.1 builds should be removed by this MR.

  • mentioned in merge request !9098 (merged)

  • I've created https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9098 with just the first commit, and set that to MWPS.

  • @smcgivern @rymai What is the status of this?

  • @zj Please update https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1195 (i.e. keep only the Rubocop commit) and assign both MRs to the same maintainer.

  • username-removed-128633 changed title from Drop support for Ruby 2.1 to Update Rubocop to Ruby 2.3

    changed title from Drop support for Ruby 2.1 to Update Rubocop to Ruby 2.3

  • assigned to @zj

  • Please register or sign in to reply
    Loading