Add pagination to environments table
What does this MR do?
This is the second of several merge requests to add pagination and a new subview for environments. In order to make it easier to review the work will be divided in 3 different Merge Requests:
-
1. Adapt to new API response - !8954 (merged) -
2. Add Pagination !9090 (merged) -
3. Add the subview to show the content of a folder !9169 (merged)
This is the Merge Request for 2. Add Pagination Adds pagination for environments table. Reuses table pagination component. Has tests.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
- [ ] Changelog entry added
- [ ] Documentation created/updated
- [ ] API support added
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
marked the task Conform by the merge request performance guides as completed
marked the task Conform by the style guides as completed
added ~19173 Deliverable frontend labels
mentioned in merge request !8954 (merged)
-
@fatihacet this is the continuation of !8954 (merged). It adds the pagination component and integrates it with the API.
Can you please review?
💪 Thank you!! assigned to @fatihacet
assigned to @filipa
added 156 commits
-
c04edc62...bd01d79f - 155 commits from branch
fe-paginated-environments-api - 8a9b20b0 - Merge branch 'fe-paginated-environments-api' into fe-paginated-environments-api-add-pagination
-
c04edc62...bd01d79f - 155 commits from branch
added 6 commits
-
b8dbebce - 1 commit from branch
fe-paginated-environments-api - 991a7ae8 - Adds pagination component
-
fb359808 - Verify
latestkey is present when needed - 595afed2 - Integrates pagination component with API
- 27d7ec70 - Remove spec checking for scope 'all' since it's no longer part of component
- 9b8e0c26 - Add pagination tests for environments table
Toggle commit list-
b8dbebce - 1 commit from branch
mentioned in merge request !9169 (merged)
marked the task Squashed related commits together as completed
-
assigned to @fatihacet
marked the task 3. Add the subview to show the content of a folder !9169 (merged) as completed
@filipa overally LGTM, added a few minor comments.
assigned to @filipa
added 2 commits
-
@fatihacet pushed some changes, only one comment to address: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9090#note_23508631
Will fix the others in the 3rd MR :D
assigned to @fatihacet
added 14 commits
- 7af6982e - Extracts table into a reusable component
- 26d18387 - First iteration
- 08234849 - Adds url for folder;
- 17897c37 - Fix underline style
- 73accafe - Use common util to get parameter name
- 1285d629 - Move change page param to utility function
- 9414fc5c - Moves check for latest key to store instead of poluting the view making it reusa…
- 9ac8bf2c - Adds Changelog entry
- 605195c2 - Fix broken tests
- 8ca90a68 - Merge branch 'fe-paginated-environments-api-add-pagination' into fe-paginated-en…
- ba53ee78 - Changes after review
- 51f03780 - Create util to handle pagination transformation
- ab3c546f - Remove arrow icon from folders
- 25c92938 - Merge branch 'fe-paginated-environments-api-add-subview' into 'fe-paginated-envi…
Toggle commit listmentioned in commit 13615ef8
