Adds sub view to list environments under a folder
What does this MR do?
Adds sub view to list environments under a folder.
This is the third of several merge requests to add pagination and a new subview for environments. In order to make it easier to review the work will be divided in 3 different Merge Requests:
-
1. Adapt to new API response - !8954 (merged) -
2. Add Pagination !9090 (merged) -
3. Add the subview to show the content of a folder !9169 (merged)
This is the Merge Request for 3. Add the subview to show the content of a folder
- Adds Folder URL
- Adds folder subview
- Extracts table into reusable component
- Extracts
latestkey added in the FE to avoid a lot of verifications and to make it reusable between both endpoints/views
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
mentioned in merge request !9090 (merged)
mentioned in merge request !8954 (merged)
added 2 commits
@grzesiek According to the mockup in this issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/25499
https://gitlab.com/gitlab-org/gitlab-ce/uploads/4914c5fcae10d8417f9efffd15a71794/image.png
The sub view for the environments of a folder, needs to have the count of available and stopped envs, is the API ready for this?
environments/folder/{id}?scope=stopped&page=2-
This is ready from the frontend side, I am assuming this endpoint:
environments/folder/{id}.json@grzesiek I also need the name of the folder. :)
Should I assign this to you?
Edited by Filipa Lacerda marked the task Conform by the merge request performance guides as completed
marked the task Conform by the style guides as completed
assigned to @grzesiek
-
@grzesiek in the meantime will assign to me to add tests and polish somethings :)
assigned to @filipa
assigned to @grzesiek
-
Assigning to @zj :)
Please see this comments:
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9169#note_23227497
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9169#note_23229524
Please assign back to me when backend is ready
💪 assigned to @zj
added 3 commits
-
84c0947d...6483bc8c - 2 commits from branch
fe-paginated-environments-api-add-pagination - 4e5a254b - Merge branch 'fe-paginated-environments-api-add-pagination' into fe-paginated-en…
-
84c0947d...6483bc8c - 2 commits from branch
added 1 commit
- a1a0bec7 - Moves check for latest key to store instead of poluting the view making it reusa…
added 7 commits
- 7af6982e - Extracts table into a reusable component
- 26d18387 - First iteration
- 08234849 - Adds url for folder;
- 17897c37 - Fix underline style
- 73accafe - Use common util to get parameter name
- 1285d629 - Move change page param to utility function
- 9414fc5c - Moves check for latest key to store instead of poluting the view making it reusa…
Toggle commit listmarked the task Changelog entry added as completed
marked the task Squashed related commits together as completed
assigned to @filipa
added 4 commits
-
605195c2...19791b65 - 2 commits from branch
fe-paginated-environments-api-add-pagination - 8ca90a68 - Merge branch 'fe-paginated-environments-api-add-pagination' into fe-paginated-en…
- ba53ee78 - Changes after review
-
605195c2...19791b65 - 2 commits from branch
-
@fatihacet pushed changes to fix the code of all your comments, the only one missing is this one from the 2nd MR
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9090#note_23508631
added 1 commit
- 51f03780 - Create util to handle pagination transformation
assigned to @fatihacet
mentioned in commit 25c92938
