Allow searching issues for strings containing colons
What does this MR do?
Allow searching for strings with colons - only tokenize keys in FilteredSearchTokenKeys.tokenKeys
Are there points in the code the reviewer needs to double check?
- Are there other filter values allowed that aren't handled in frontend?
Why was this MR needed?
Searching double colon can be common for code snippets
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #28357 (closed)
Merge request reports
Activity
marked the task Changelog entry added as completed
marked the task
Documentation created/updatedas completedassigned to @ClemMakesApps
- Resolved by Simon Knox
59 66 // Reposition dropdown so that it is aligned with cursor 60 67 this.dropdownManager.updateCurrentDropdownOffset(); 61 68 } 62 69 } 63 70 64 71 checkForEnter(e) { 65 if (e.keyCode === 38 || e.keyCode === 40) { 72 if (e.keyCode === KEYCODE.UP || e.keyCode === KEYCODE.DOWN) { 66 73 const selectionStart = this.filteredSearchInput.selectionStart; 67 74 68 75 e.preventDefault(); 69 76 this.filteredSearchInput.setSelectionRange(selectionStart, selectionStart); 70 77 } 71 78 72 if (e.keyCode === 13) { 79 if (e.keyCode === KEYCODE.ENTER) { assigned to @psimyn
changed milestone to %8.16
added 1 commit
- fe1ab405 - Allow searching issues for strings containing colons
marked the task Squashed related commits together as completed
assigned to @ClemMakesApps
LGTM, Thanks @psimyn
I'm setting it to MWPS
enabled an automatic merge when the pipeline for fe1ab405 succeeds
@ClemMakesApps is this also needed in 8.17?
Please register or sign in to reply