Skip to content
Snippets Groups Projects

Allow searching issues for strings containing colons

Merged Simon Knox requested to merge 28357-colon-search into master

What does this MR do?

Allow searching for strings with colons - only tokenize keys in FilteredSearchTokenKeys.tokenKeys

Are there points in the code the reviewer needs to double check?

  • Are there other filter values allowed that aren't handled in frontend?

Why was this MR needed?

Searching double colon can be common for code snippets

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #28357 (closed)

Merge request reports

Pipeline #6592819 passed

Pipeline passed for fe1ab405 on 28357-colon-search

Test coverage 93.42% (0.21%) from 1 job

Merged by username-removed-408677username-removed-408677 8 years ago (Feb 21, 2017 2:08am UTC)

Loading

Pipeline #6593719 passed

Pipeline passed for b596dd8f on master

Test coverage 93.44% (0.21%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 59 66 // Reposition dropdown so that it is aligned with cursor
    60 67 this.dropdownManager.updateCurrentDropdownOffset();
    61 68 }
    62 69 }
    63 70
    64 71 checkForEnter(e) {
    65 if (e.keyCode === 38 || e.keyCode === 40) {
    72 if (e.keyCode === KEYCODE.UP || e.keyCode === KEYCODE.DOWN) {
    66 73 const selectionStart = this.filteredSearchInput.selectionStart;
    67 74
    68 75 e.preventDefault();
    69 76 this.filteredSearchInput.setSelectionRange(selectionStart, selectionStart);
    70 77 }
    71 78
    72 if (e.keyCode === 13) {
    79 if (e.keyCode === KEYCODE.ENTER) {
  • added ~149423 label

  • changed milestone to %8.16

  • Simon Knox added 1 commit

    added 1 commit

    • fe1ab405 - Allow searching issues for strings containing colons

    Compare with previous version

  • marked the task Squashed related commits together as completed

  • Simon Knox marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

    marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • Simon Knox marked the task All builds are passing as completed

    marked the task All builds are passing as completed

  • LGTM, Thanks @psimyn :100:

    I'm setting it to MWPS

  • username-removed-408677 enabled an automatic merge when the pipeline for fe1ab405 succeeds

    enabled an automatic merge when the pipeline for fe1ab405 succeeds

  • @ClemMakesApps is this also needed in 8.17?

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading