Fix build attributes test

What does this MR do?

This is a follow up from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9021#note_23782188

Description

Fix build attributes test, see:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9021#note_23782188

This is discovered by https://gitlab.com/gitlab-org/gitlab-ce/builds/10815456

I removed gl_project_id and this is failing. I took some look, realizing that:

• trace is duplicated in attributes
• tag_list is not included in build.attributes
• artifacts_expire_at is missing in attributes

So we need to:

• Remove duplicated trace in attributes (40 -> 39)
• Remove tag_list in attributes (39 -> 38)
• Add artifacts_expire_at to attributes (38 -> 39)
• Add gl_project_id to attributes (39 -> 40)

/cc @ayufan

Note that we'll remove gl_project_id again in !9378 (closed)

@godfat I left just a single question. It looks good to me Thanks for fixing this!

assigned to @godfat

mentioned in commit 9e6b2c5d

resolved all discussions

added 1 commit

• 9e6b2c5d - We actually want to clone project and remove gl_project_id

Compare with previous version

@grzesiek No problems. I forgot to assign back :P

assigned to @grzesiek

Looks good to me! Thanks @godfat

assigned to @ayufan

mentioned in commit cfd7602d

merged