Fix link togglers jumping to top

What does this MR do?

• Update .js-toggle-button to be actual button tags

Using <button> is semantically more accurate for the usage and we don't need the previous e.preventDefault() unless inside a <form>

Are there points in the code the reviewer needs to double check?

Togglers to check:

• "Create a Mattermost team for this group" Checkbox, http://localhost:3000/groups/new (enable mattermost in config/gitlab.yml)
• "Repo by Url" button, http://localhost:3000/projects/new
• In MR widget "Modify commit message", http://localhost:3000/gitlab-org/gitlab-ce/merge_requests/9
• Discussion "Toggle discussion", http://localhost:3000/gitlab-org/gitlab-ce/merge_requests/3
• "Showing 1 changed file with 4 additions and 7 deletions" , http://localhost:3000/gitlab-org/gitlab-ce/merge_requests/3/diffs
• Commit description toggle "...", http://localhost:3000/gitlab-org/gitlab-ce/commits/master

Why was this MR needed?

• We used a tags with empty fragment href="#" which would jump you to the top of the page when clicked

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added
• Tests
  • All builds are passing
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes #29414 (closed)

added 1 commit

• d408e815 - Fix link togglers jumping to top

Compare with previous version

Hover is different to what we currently have in prod

assigned to @MadLittleMods

resolved all discussions

added 1 commit

• 0e41b10f - 1 commit from branch master

Compare with previous version

assigned to @iamphill

added 33 commits

• 0e41b10f...ffcddb29 - 32 commits from branch master
• cf8dec2d - Fix link togglers jumping to top

Compare with previous version

I think the button refactor is doing too much for something post-feature-freeze. Maybe we should just fix the current regression for 9.0 and address the refactor for 9.1.

Can you address the comment from @rspeicher?

assigned to @MadLittleMods

changed milestone to %9.1

removed ~149423 label

@rspeicher @iamphill I created https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9943 which includes just enough to fix the issue for 9.0.

We can merge this <button> refactor in 9.1

assigned to @iamphill

resolved all discussions

mentioned in merge request !9943 (merged)

marked the task All builds are passing as completed

assigned to @fatihacet

@fatihacet Friendly ping for review (not critical)

@fatihacet Timeline for review?

added 427 commits

• cf8dec2d...45a2f900 - 426 commits from branch master
• 53b0b1a5 - Fix link togglers jumping to top

Compare with previous version

mentioned in commit d4c8e847

mentioned in merge request !10126 (merged)

@MadLittleMods build failed.

@jschatz1 can you review this for me?

assigned to @MadLittleMods

assigned to @jschatz1

added 360 commits

• 53b0b1a5...6460489b - 359 commits from branch master
• cf3c4398 - Fix link togglers jumping to top

Compare with previous version

approved this merge request

merged

mentioned in commit 01b5d885