Skip to content
Snippets Groups Projects

Improve the MR guidelines from the CONTRIBUTING guide

Merged username-removed-128633 requested to merge improve-mr-reviews-in-contributing into master

What does this MR do?

This addresses a feedback from @jschatz1 (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9839#note_25100703) about specs that are considered backend code.

It also add details about approvals:

  • you can require more than 1 approval (suggested by @DouweM in Tuesday team call agenda on @filipa's item)
  • you can choose specific approvers if you want to (for very specific subjects, it can make sense)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading