Skip to content

cache-extractor command returns an error on 404

username-removed-527833 requested to merge MrTrustor/gitlab-ci-multi-runner:1965-extractor-fix into master

What does this MR do?

It changes the exit code of the cache-extractor command if the provided URL returns a 404. It was 0, it is now 1.

Why was this MR needed?

As explained in #1965 (closed) the exit code 0 leads to a confusing "Cache extracted successfully!" in the build log.

Are there points in the code the reviewer needs to double check?

No.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #1965 (closed)

Merge request reports