Support for extended docker configuration in gitlab-ci.yml

What does this MR do?

Adds support for some Docker configuration options set with .gitlab-ci.yml file. Needs gitlab-org/gitlab-ce!8578 to work, because .gitlab-ci.yml is parsed in GitLab CE/EE and then job configuration is send to Runner. This MR adds support for new configuration options available in job's payload.

Why was this MR needed?

Please look into: #1466 (closed), #1421 (closed), #1284 (closed) for reference.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

• Documentation created/updated
• Tests
  • Added for this feature/bug
  • All builds are passing
• Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #1466 (closed), #1421 (closed), #1284 (closed)

@ayufan Could you review this?

mentioned in merge request !535 (merged)

@tmaczukin I believe that we should also implement that to Kubernetes. We use Kubernetes on pair with Docker nowadays and we should not introduce that big of the difference.

Also, I don't see any documentation for that. Where we want to document compatibility of that feature?

@ayufan I'm still working on this MR, so the documentation will be added. I can also update the Kubernetes executor. Just wanted to have an early response about the approach taken here :)

mentioned in issue #1454

changed milestone to %9.4

added executordocker executordocker-machine labels

added executorkubernetes label

mentioned in issue #2460

resolved all discussions

@ayufan I've added support for Kubernetes. Documentation is on the way :)

assigned to @ayufan

changed the description

mentioned in merge request gitlab-com/www-gitlab-com!6239 (merged)

changed milestone to %10.0

changed milestone to %9.4

approved this merge request

merged

mentioned in issue #2625

mentioned in merge request !635 (merged)

mentioned in issue #2636 (closed)

mentioned in merge request !641 (merged)

@bikebilly @tmaczukin Can we get docs for this please? Support thought it could be relevant to something we need, but looking at the code it's not abundantly clear what this is, and how to use it.

@lbot We've added documentation with gitlab-org/gitlab-ce!12164, in the same release when the feature was added. It's available at the links posted by @bikebilly.

Hello,

I want to use those extended options (namely: alias) in /etc/gitlab-runner/config.toml. Is it possible?

i.e (look at the services line):

[[runners]]
  name = "foo"
  url = "https://gitlab.example.org/"
  token = "abcd"
  executor = "docker"
  [runners.docker]
    tls_verify = false
    image = "docker-registry.example.org:443/local_docker/paas:docker-latest"
    services = ["dind=docker-registry.example.org:443/local_docker/paas:docker-dind"]
    privileged = true
    disable_cache = false
    allowed_images = ["docker-registry.example.org:443/local_docker/paas:docker-latest"]
    allowed_services = ["docker-registry.example.org:443/local_docker/paas:docker-dind"]
    pull_policy = "always"
  [runners.cache]

@sathieu No, this configuration is currently supported only from .gitlab-ci.yml file.