EE port: Properly expire cache for **all** MRs of a pipeline
EE port of gitlab-org/gitlab-ce!10770
What does this MR do?
It ensures the Etag cache gets expired for all MRs for which the pipeline runs/ran against, and not just the MRs for which the pipeline runs/ran on the latest commit.
To ensure the state transitions of the pipelines are not slowed down, the ExpirePipelineCacheService is transformed into a worker.
Merge request reports
Activity
@to1ne: Does this need Pick into Stable?
@timothyandrew Thanks, yes, please do!
@to1ne This is not updated from the CE correspondence. Actually, I am not sure if this is needed as we could just synchronize from CE to EE. Not sure if there are conflicts though.
assigned to @to1ne
added 367 commits
-
f13362cd...84779047 - 363 commits from branch
master
- 676ff2bd - Properly expire cache for all MRs of a pipeline
- 6e71701b - Use a better performing query to find all MRs for pipeline
- 4df5cde6 - Refactor ExpirePipelineCacheWorker#perform
- 52a696d1 - Simplify specs and remove unnecessary attributes
Toggle commit list-
f13362cd...84779047 - 363 commits from branch
@godfat Sorry, I totally forgot to do that.
@timothyandrew I've repicked the commits from CE, so we should be good to go now. Sorry about that.
added 6 commits
-
52a696d1...9cb1a114 - 2 commits from branch
master
- f93ff18d - Properly expire cache for all MRs of a pipeline
- c6147da5 - Use a better performing query to find all MRs for pipeline
- c0e747d8 - Refactor ExpirePipelineCacheWorker#perform
- efa54ad2 - Simplify specs and remove unnecessary attributes
Toggle commit list-
52a696d1...9cb1a114 - 2 commits from branch
@to1ne: Thanks. We'll pick this to
9-1-stable
once this is merged toee/master
.@ayufan Can we merge this one too?
assigned to @ayufan
added 162 commits
-
efa54ad2...b8988cb6 - 158 commits from branch
master
- da088e6d - Properly expire cache for all MRs of a pipeline
- dcb10d10 - Use a better performing query to find all MRs for pipeline
- 6e4026e7 - Refactor ExpirePipelineCacheWorker#perform
- 76637c85 - Simplify specs and remove unnecessary attributes
Toggle commit list-
efa54ad2...b8988cb6 - 158 commits from branch
@timothyandrew The spec failures seem unrelated. Is this ready to Pick into Stable ?
@to1ne I believe this is already in
9-1-stable-ee
and released in9.1.1
because we merged from9-1-stable
to9-1-stable-ee
.changed milestone to %9.1