Use rspec-parameterized for table-based tests
What does this MR do?
Adds the rspec-parameterized
gem, documents it, and converts a number of existing ad-hoc table-based tests to use the framework as a proof of concept.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Action point from %9.4 retrospective
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
added 128 commits
- 815fe7d4...0d88bc8e - 127 commits from branch
gitlab-org:master
- 51bc3a26 - Use rspec-parameterized for table-based tests
- 815fe7d4...0d88bc8e - 127 commits from branch
added 1 commit
- 082fa66e - Use rspec-parameterized for table-based tests
- Resolved by Robert Speicher
- Resolved by Robert Speicher
- Resolved by Robert Speicher
- Resolved by Robert Speicher
- Resolved by Robert Speicher
@nick.thomas Thanks. Have a couple "thinking-out-loud" observations I'd appreciate your feedback on.
assigned to @nick.thomas
Thanks for looking @rspeicher , responses made. Just let me know if you want any changes! I'll leave it assigned to me for now.
changed milestone to %10.0
assigned to @rspeicher
mentioned in commit f460db81
Picked this for https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2868, will merge into
9-5-stable-ee
, ready for 9.5.5mentioned in commit 2c1ce91a