Skip to content
Snippets Groups Projects

Use rspec-parameterized for table-based tests

Merged Nick Thomas requested to merge nick.thomas/gitlab-ee:35804-table-based-testing into master
All threads resolved!

What does this MR do?

Adds the rspec-parameterized gem, documents it, and converts a number of existing ad-hoc table-based tests to use the framework as a proof of concept.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Action point from %9.4 retrospective

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Related to https://gitlab.com/gitlab-org/gitlab-ce/35804

Merge request reports

Pipeline #10793979 passed

Pipeline passed for 082fa66e on nick.thomas:35804-table-based-testing

Test coverage 70.08% (21.71%) from 2 jobs

Merged by Robert SpeicherRobert Speicher 7 years ago (Aug 14, 2017 6:12pm UTC)

Loading

Pipeline #10862527 failed

Pipeline failed for f460db81 on master

Test coverage 48.36% (21.71%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robert Speicher
  • Robert Speicher
  • Robert Speicher
  • Robert Speicher
  • @nick.thomas Thanks. Have a couple "thinking-out-loud" observations I'd appreciate your feedback on. :thumbsup:

  • Author Maintainer

    Thanks for looking @rspeicher , responses made. Just let me know if you want any changes! I'll leave it assigned to me for now.

  • Robert Speicher resolved all discussions

    resolved all discussions

  • Robert Speicher approved this merge request

    approved this merge request

  • Robert Speicher changed milestone to %10.0

    changed milestone to %10.0

  • Robert Speicher mentioned in commit f460db81

    mentioned in commit f460db81

  • Picked this for https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2868, will merge into 9-5-stable-ee, ready for 9.5.5

  • Robert Speicher mentioned in commit 2c1ce91a

    mentioned in commit 2c1ce91a

  • Please register or sign in to reply
    Loading