Remove unneeded sidebar class

Closes #3218 (closed)

@ClemMakesApps can you please review?

assigned to @ClemMakesApps

@annabeldunstone

$git grep js-page-with-sidebar
app/assets/javascripts/ee_trial_banner/ee_trial_banner.js:    this.$secondaryNavbar = this.$mainNavbar.siblings('.js-page-with-sidebar');

I don't think we should remove that selector

$git grep page-with-new-sidebar
app/assets/javascripts/new_sidebar.js:      this.$page.toggleClass('page-with-new-sidebar', !collapsed);
app/assets/stylesheets/new_sidebar.scss:.page-with-new-sidebar {
app/assets/stylesheets/pages/boards.scss:.page-with-new-sidebar.page-with-sidebar .issue-boards-sidebar {
app/helpers/nav_helper.rb:    class_name << 'page-with-new-sidebar' if defined?(@new_sidebar) && @new_sidebar

I tested the branch locally and it seemed to fix the problem, but it still seems like we are referencing these classes that are being removed

assigned to @annabeldunstone

$git grep js-page-with-sidebar

Good point; I'll put it back

$git grep page-with-new-sidebar

We're still using the class; it's now just moved to the helper in nav_helper.rb

added 1 commit

• 1021f4dc - Remove unneeded sidebar class

Compare with previous version

assigned to @ClemMakesApps

Tested it out and looks good to me. Thanks @annabeldunstone

approved this merge request

merged

mentioned in commit 066cdfd6

mentioned in commit 876ebfc8

Picked into https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2739, will merge into 9-5-stable-ee ready for 9.5.1-ee

removed Pick into Stable label