Fix over-nesting of artifacts object store settings

Closes #2640 (closed)

changed milestone to %9.4

@marin If this is indeed what we need, do we want an MR against 9-3-stable also? As object storage was introduced in that version.

assigned to @balasankarc

@balasankarc Thanks for the fix!

This problem was not obvious to me when I was peeking through the omnibus code. At first, I thought it was just a simple oversight of missing Mash.new in the Omnnibus gitlab.rb. Are there guidelines somewhere that point us to when we should or should not add another layer of nesting and what a contributor has to do to make that work?

added 15 commits

• d5883970...19a72ffd - 13 commits from branch master
• eb492776 - Fix over-nesting of artifacts object store settings
• 7bec06d0 - Enhance existing test

Compare with previous version

@marin I just verified the changes actually work and the user specified valued correctly get propagated to gitlab.yml file. Also modified the tests to match it.

assigned to @marin

approved this merge request

merged

mentioned in commit 929fae37

Release manager note: Once this is picked into 9.4, please change the milestone to 9.3 too and pick to those stable branches as well.

@stanhu I don't think we currently have guidelines regarding this. But, with https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1824 the situation may change and we will be able to deeply nest settings.

Picked into 9-4-stable ready for 9.4.5

Leaving Pick into Stable label and changing milestone to 9.3 as requested.

mentioned in commit 984fa7d9

actually, @marin it seems milestone 9.3 is inaccessible... has it been archived/closed already? how should I tag this to ensure it gets seen when the next 9.3.x is tagged?

I've re-opened milestone %9.3 and assigned this to it.

changed milestone to %9.3

mentioned in merge request !1914 (merged)