WIP: Use environment variables to configure Mattermost
Depends on: !1959 (merged)
Closes #2377
Merge request reports
Activity
mentioned in issue #2377
mentioned in merge request !1677 (merged)
added 15 commits
- 3e137ba9...674d0531 - 10 commits from branch
master - 4885a601 - Use config.json instead of template
- a62996fe - Remove unwanted configuration
- ad12c0cd - Set necessary env variables
- 77c82449 - Remove use of config.json
- c9b2c799 - Provide upstream config.json as a template to users
Toggle commit list- 3e137ba9...674d0531 - 10 commits from branch
added 130 commits
- 0e62fe81...aad66d28 - 127 commits from branch
master - d9619d3b - Remove default values for all settings other than 13 needed ones
- bf7269b9 - Pass every mattermost related setting as env variable
- 56a329a8 - Ship curated json file
Toggle commit list- 0e62fe81...aad66d28 - 127 commits from branch
@twk3 I wrote a library function that automatically converts gitlab.rb settings to env variables. I am yet to test it, but it would be great if you could take a glance and see if there are any obvious issues.
changed milestone to %10.1
added 86 commits
- 007e35f5...3f5489e1 - 75 commits from branch
master - e039dc71 - Remove default values for all settings other than 13 needed ones
- ebd805fd - Pass every mattermost related setting as env variable
- f24b1ae2 - Ship curated json file
- d937943c - Move default values to helper
- 0fefbfd4 - Convert everything to string and fix typo
- b4bff1ce - Fix variable type
- 3706fc3d - Pass node variable to helper
- 81f0e29e - Skip DataSourceReplicas and DataSourceSearchReplicas as they are EE only
- a0eace98 - Remove DataSourceReplicas from necessary list
- 8f2be096 - Remove setting of data source replicas
- 0ad410c5 - Convert env_dir to a custom resource
Toggle commit list- 007e35f5...3f5489e1 - 75 commits from branch
-
@twk3 This is ready for an initial review (tests are todo). I will test if this change works fine with other mattermost settings (with no other settings that use arrays or hashes, I don't think anything else is broken, but still.)
If needed, I will push the commit that makes env_dir a resource (rather than a definition) along with the test fixes as a different MR. WDYT?
@balasankarc yeah, I think moving the env_dir resource part into it's own MR will be a good thing. I will also log an issue around the LWRP tests, as the current way we are doing them is actually causing more work.
mentioned in merge request !1959 (merged)
added 1 commit
- 64848e10 - Revert "Convert env_dir to a custom resource"
-
@twk3 Reverted the env_dir change in this MR. Opened !1959 (merged) to add that and discuss about custom resource tests, with reference to #2804 .
