Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

merge_request_diff.rb

Forked from GitLab.org / GitLab FOSS
Source project has a limited visibility.
  • Sean McGivern's avatar
    27fdd3fe
    Maintain commit order in MRs · 27fdd3fe
    Sean McGivern authored
    `Gitlab::Git::Compare` will already have the correct order; sorting in
    Ruby can only ruin that. (The correct order being the same as `git log`
    - reverse chronological while maintaining the commit graph.)
    
    As an example, imagine a branch where someone has their system clock set
    wrong for some of the commits. Not only will those commits be in the
    wrong order - which is maybe reasonable - but sorting in Ruby can also
    put commits with the same timestamp out of order, as Ruby's sorting
    isn't stable.
    27fdd3fe
    History
    Maintain commit order in MRs
    Sean McGivern authored
    `Gitlab::Git::Compare` will already have the correct order; sorting in
    Ruby can only ruin that. (The correct order being the same as `git log`
    - reverse chronological while maintaining the commit graph.)
    
    As an example, imagine a branch where someone has their system clock set
    wrong for some of the commits. Not only will those commits be in the
    wrong order - which is maybe reasonable - but sorting in Ruby can also
    put commits with the same timestamp out of order, as Ruby's sorting
    isn't stable.