Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

json_response_helpers.rb

Forked from GitLab.org / GitLab FOSS
Source project has a limited visibility.
  • Rémy Coutable's avatar
    5f7592d5
    Implement `json_response` as a `let` variable · 5f7592d5
    Rémy Coutable authored
    
    This is not a good idea to memoize `json_response` using an instance
    variable because `rspec-retry` doesn't clear instance variables on
    retries, only `let` variables.
    
    This will avoid issues where retries would fail on a different line that
    the original failure, blurrying what's the real failure.
    
    Also, automatically add api: true to specs under
    /spec/requests/(ci/)?api/, and include JsonHelpers in controller, request
    and API specs.
    
    Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
    5f7592d5
    History
    Implement `json_response` as a `let` variable
    Rémy Coutable authored
    
    This is not a good idea to memoize `json_response` using an instance
    variable because `rspec-retry` doesn't clear instance variables on
    retries, only `let` variables.
    
    This will avoid issues where retries would fail on a different line that
    the original failure, blurrying what's the real failure.
    
    Also, automatically add api: true to specs under
    /spec/requests/(ci/)?api/, and include JsonHelpers in controller, request
    and API specs.
    
    Signed-off-by: default avatarRémy Coutable <remy@rymai.me>