Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

merge_request.rb

Blame
Forked from GitLab.org / GitLab FOSS
Source project has a limited visibility.
  • Lin Jen-Shin's avatar
    3ae99b2c
    If merge request wasn't persisted yet, we show only 1 pipeline: · 3ae99b2c
    Lin Jen-Shin authored 
    However, if MergeRequest#all_commits_sha would want to handle
non-persisted merge request, by judging its name, it should not
just give 1 SHA, but all of them.

But we don't really care all_commits_sha for non-persisted merge
request anyway. So I think we should just ignore that case.

Better to not implementing something than implementing it in a
wrong and confusing way.
    3ae99b2c
    History
    If merge request wasn't persisted yet, we show only 1 pipeline:
    Lin Jen-Shin authored 
    However, if MergeRequest#all_commits_sha would want to handle
non-persisted merge request, by judging its name, it should not
just give 1 SHA, but all of them.

But we don't really care all_commits_sha for non-persisted merge
request anyway. So I think we should just ignore that case.

Better to not implementing something than implementing it in a
wrong and confusing way.