Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

notes_on_merge_requests_spec.rb

Forked from GitLab.org / GitLab FOSS
46474 commits behind the upstream repository.
  • Izaak Alpert's avatar
    489fa5d7
    MR on Fork multiple fixes · 489fa5d7
    Izaak Alpert authored
    -Disable observers post test run
    -Allow db:seed_fu RAILS_ENV=test to be run more than once without error
    -fix diffs_in_between, was passing in the default_options for grit, but grit in this case doesn't take options, fixed the test to actually fail if the incorrect diffs are returned
    -make notes/commits render against proper project
    -MR discussion file links should reference note's project
    -Added tests for commit links on edit merge request
    -fixes edit issues (canceling an edited mr, updating an edited mr)
    -updates tests with checks for source code updates
    -still forked_merge_requests.feature (project_forked_merge_requests) test not passing (commented out -- "stable" not being set)
    
    MR API: error on bad target_project
    
    -If the target project id is specified and it is not the same as the project the request is being made on (the source), and the it isn't a fork of that project, error out, otherwise use it as the target
    -Fixes some busted (but hidden) test cases
    
    Conflicts:
    	app/views/merge_requests/show/_diffs.html.haml
    	spec/features/notes_on_merge_requests_spec.rb
    
    Change-Id: I20e595c156d0e8a63048baaead7be6330c738a05
    489fa5d7
    History
    MR on Fork multiple fixes
    Izaak Alpert authored
    -Disable observers post test run
    -Allow db:seed_fu RAILS_ENV=test to be run more than once without error
    -fix diffs_in_between, was passing in the default_options for grit, but grit in this case doesn't take options, fixed the test to actually fail if the incorrect diffs are returned
    -make notes/commits render against proper project
    -MR discussion file links should reference note's project
    -Added tests for commit links on edit merge request
    -fixes edit issues (canceling an edited mr, updating an edited mr)
    -updates tests with checks for source code updates
    -still forked_merge_requests.feature (project_forked_merge_requests) test not passing (commented out -- "stable" not being set)
    
    MR API: error on bad target_project
    
    -If the target project id is specified and it is not the same as the project the request is being made on (the source), and the it isn't a fork of that project, error out, otherwise use it as the target
    -Fixes some busted (but hidden) test cases
    
    Conflicts:
    	app/views/merge_requests/show/_diffs.html.haml
    	spec/features/notes_on_merge_requests_spec.rb
    
    Change-Id: I20e595c156d0e8a63048baaead7be6330c738a05
notes_on_merge_requests_spec.rb 9.78 KiB