Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

diff_helper.rb

Forked from GitLab.org / GitLab FOSS
Source project has a limited visibility.
  • Robert Speicher's avatar
    90a67a76
    Always read diff_view setting from the cookie · 90a67a76
    Robert Speicher authored
    Prior, when the user had their view set to "parallel" and then visited a
    merge request's changes tab _without_ passing the `view` parameter via
    query string, the view would be parallel but the `Notes` class was
    always instantiated with the default value from `diff_view` ("inline"),
    resulting in broken markup when the form to add a line note was
    dynamically inserted.
    
    The cookie is set whenever the view is changed, so this value should
    always be up-to-date.
    
    Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14557
    90a67a76
    History
    Always read diff_view setting from the cookie
    Robert Speicher authored
    Prior, when the user had their view set to "parallel" and then visited a
    merge request's changes tab _without_ passing the `view` parameter via
    query string, the view would be parallel but the `Notes` class was
    always instantiated with the default value from `diff_view` ("inline"),
    resulting in broken markup when the form to add a line note was
    dynamically inserted.
    
    The cookie is set whenever the view is changed, so this value should
    always be up-to-date.
    
    Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14557